third_party/WebKit/Source/core/loader/NavigationScheduler.h - Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.h

Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler. (Closed)

Patch Set: addressing comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/NavigationScheduler.h

diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.h b/third_party/WebKit/Source/core/loader/NavigationScheduler.h

index 10d870e116bf155873a06e0a9b86d7d5b5e54892..3e14352acfffaa25f2ac25c11def10f9854dbdf9 100644

--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.h

+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.h

@@ -96,13 +96,13 @@ class CORE_EXPORT NavigationScheduler final

WebScheduler::NavigatingFrameType m_frameType;

};

-class NavigationDisablerForUnload {

- WTF_MAKE_NONCOPYABLE(NavigationDisablerForUnload);

+class NavigationDisablerForBeforeUnload {

+ WTF_MAKE_NONCOPYABLE(NavigationDisablerForBeforeUnload);

STACK_ALLOCATED();

public:

- NavigationDisablerForUnload() { s_navigationDisableCount++; }

- ~NavigationDisablerForUnload() {

+ NavigationDisablerForBeforeUnload() { s_navigationDisableCount++; }

+ ~NavigationDisablerForBeforeUnload() {

DCHECK(s_navigationDisableCount);

s_navigationDisableCount--;

}