third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler. (Closed)

Patch Set: addressing comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 36b71712621945b2dd1d631db89dcb742d92e0be..e7e40a3a152222afa8d3396818fe7222ce70f4fe 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -923,6 +923,10 @@ FrameNavigationDisabler::~FrameNavigationDisabler() {

m_frame->enableNavigation();

}

+bool LocalFrame::isNavigationAllowed() const {

+ return m_navigationDisableCount == 0;

dcheng 2017/01/09 19:17:30 Nit: revert this to the original (inlined in heade

lfg 2017/01/09 21:18:22 Done.

ScopedFrameBlamer::ScopedFrameBlamer(LocalFrame* frame) : m_frame(frame) {

if (m_frame && m_frame->client() && m_frame->client()->frameBlameContext())

m_frame->client()->frameBlameContext()->Enter();