third_party/WebKit/LayoutTests/fast/events/before-unload-forbidden-navigation.html - Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/before-unload-forbidden-navigation.html

Issue 2487403002: Allow navigations to frames that aren't being unloaded in the unload handler. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/navigation/resources/targeted-navigation-in-unload-handler-subframe.html » ('j') | third_party/WebKit/Source/core/frame/History.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <p>This test ensures navigation is forbidden while beforeunload event is being f ired. You should see PASS 1/2 and PASS 2/2 below:</p>	4 <p>This test ensures navigation is forbidden while beforeunload event is being f ired. You should see PASS 1/2 and PASS 2/2 below:</p>

5 <pre id="log">FAIL</pre>	5 <pre id="log">FAIL</pre>

6 <script>	6 <script>

7	7

8 if (window.testRunner) {	8 if (window.testRunner) {

9 testRunner.dumpAsText();	9 testRunner.dumpAsText();

10 testRunner.dumpChildFramesAsText();	10 testRunner.dumpChildFramesAsText();

11 testRunner.waitUntilDone();	11 testRunner.waitUntilDone();

12 }	12 }

13	13

14 var log = document.getElementById('log');	14 var log = document.getElementById('log');

15	15

16 function test(iframe) {	16 function test(iframe) {

17 if (iframe.done) {	17 if (iframe.done) {

18 if (iframe.halfPassed) {	18 if (iframe.halfPassed) {

19 iframe.contentWindow.location.href = 'resources/before-unload-in-sub frame-destination.html';	19 iframe.contentWindow.location.href = 'resources/before-unload-in-sub frame-destination.html';

20 iframe.halfPassed = false;	20 iframe.halfPassed = false;

21 }	21 }

22 return;	22 return;

23 }	23 }

24 iframe.done = true;	24 iframe.done = true;

25 iframe.contentWindow.location.href = 'resources/before-unload-in-subframe-ch ild.html';	25 iframe.contentWindow.location.href = 'resources/before-unload-in-subframe-ch ild.html';

26 }	26 }

27	27

28 function fired(contentWindow) {	28 function fired(contentWindow) {

29 location.href = 'resources/before-unload-in-subframe-fail.html';
lfg 2016/11/10 00:15:04 This test was navigating the top-level frame in th This test was navigating the top-level frame in the unload handler of a subframe. This is allowed after my change. The test is still relevant though, since it tests that the subframe won't navigate on its own unload handler.
30 contentWindow.location.href = 'resources/before-unload-in-subframe-fail.html ';	29 contentWindow.location.href = 'resources/before-unload-in-subframe-fail.html ';

31 log.innerHTML = 'PASS 1/2';	30 log.innerHTML = 'PASS 1/2';

32 contentWindow.frameElement.halfPassed = true;	31 contentWindow.frameElement.halfPassed = true;

33 }	32 }

34	33

35 </script>	34 </script>

36 <iframe onload="test(this);" src="resources/before-unload-in-subframe-child.html "></iframe>	35 <iframe onload="test(this);" src="resources/before-unload-in-subframe-child.html "></iframe>

37 </body>	36 </body>

38 </html>	37 </html>

OLD	NEW