DevTools: settings of custom devtools should not interfere with bundled devtools

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @unrestricted
  */
 WebInspector.Settings = class {
   /**
-   * @param {!WebInspector.SettingsStorage} storage
+   * @param {!WebInspector.SettingsStorage} globalStorage
+   * @param {!WebInspector.SettingsStorage} localStorage
    */
-  constructor(storage) {
-    this._settingsStorage = storage;
-    var clearLocalStorage = window.localStorage ? window.localStorage.clear.bind(window.localStorage) : undefined;
-    this._localStorage =
-        new WebInspector.SettingsStorage(window.localStorage || {}, undefined, undefined, clearLocalStorage);
+  constructor(globalStorage, localStorage) {
+    this._settingsStorage = globalStorage;
+    this._localStorage = localStorage;
 
     this._eventSupport = new WebInspector.Object();
     /** @type {!Map<string, !WebInspector.Setting>} */
     this._registry = new Map();
     /** @type {!Map<string, !WebInspector.Setting>} */
     this._moduleSettings = new Map();
     self.runtime.extensions('setting').forEach(this._registerModuleSetting.bind(this));
   }
 
   /**
@@ skipping 81 matching lines @@
 
 /**
  * @unrestricted
  */
 WebInspector.SettingsStorage = class {
   /**
    * @param {!Object} object
    * @param {function(string, string)=} setCallback
    * @param {function(string)=} removeCallback
    * @param {function(string)=} removeAllCallback
+   * @param {string=} storagePrefix
    */
-  constructor(object, setCallback, removeCallback, removeAllCallback) {
+  constructor(object, setCallback, removeCallback, removeAllCallback, storagePrefix) {
     this._object = object;
     this._setCallback = setCallback || function() {};
     this._removeCallback = removeCallback || function() {};
     this._removeAllCallback = removeAllCallback || function() {};
+    this._storagePrefix = storagePrefix || '';
   }
 
   /**
    * @param {string} name
    * @param {string} value
    */
   set(name, value) {
+    name = this._storagePrefix + name;
     this._object[name] = value;
     this._setCallback(name, value);
   }
 
   /**
    * @param {string} name
    * @return {boolean}
    */
   has(name) {
+    name = this._storagePrefix + name;
     return name in this._object;
   }
 
   /**
    * @param {string} name
    * @return {string}
    */
   get(name) {
+    name = this._storagePrefix + name;
     return this._object[name];
   }
 
   /**
    * @param {string} name
    */
   remove(name) {
+    name = this._storagePrefix + name;
     delete this._object[name];
     this._removeCallback(name);
   }
 
   removeAll() {
     this._object = {};
     this._removeAllCallback();
   }
 
   _dumpSizes() {
@@ skipping 539 matching lines @@
   return WebInspector.settings.moduleSetting(settingName);
 };
 
 /**
  * @param {string} settingName
  * @return {!WebInspector.Setting}
  */
 WebInspector.settingForTest = function(settingName) {
   return WebInspector.settings.settingForTest(settingName);
 };