DevTools: settings of custom devtools should not interfere with bundled devtools

DevTools: settings of custom devtools should not interfere with bundled devtools

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch makes WI.SettingStorage to use a prefix for all the keys
being stored in case of custom frontend.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman

Committed: https://crrev.com/7abe75523c7e774d534ec529146b86f6b25c05f3
Cr-Commit-Position: refs/heads/master@{#431309}

[lushnikov, 2016-11-09 23:17:58]

please, take a look

[lushnikov, 2016-11-09 23:18:05]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 23:18:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 00:40:32]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-10 18:58:25]

lgtm

[lushnikov, 2016-11-10 18:59:06]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:59:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 19:05:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 19:10:11]

Description was changed from

==========
DevTools: settings of custom devtools should not interfere with bundled devtools

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch makes WI.SettingStorage to use a prefix for all the keys
being stored in case of custom frontend.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman
==========

to

==========
DevTools: settings of custom devtools should not interfere with bundled devtools

Currently, changing a setting inside custom devtools front-end (the one
served through chrome-devtools://devtools/custom) will change the same
setting inside bundled devtools.

This is unfortunate. In the setup we aim for, the custom devtools
are inspected by the bundled devtools, and we want them to be
independent of each other.

This patch makes WI.SettingStorage to use a prefix for all the keys
being stored in case of custom frontend.

Note: settings will be isolated, whereas experiments won't.

BUG=629914
R=dgozman

Committed: https://crrev.com/7abe75523c7e774d534ec529146b86f6b25c05f3
Cr-Commit-Position: refs/heads/master@{#431309}
==========

[commit-bot: I haz the power, 2016-11-10 19:10:12]

Patchset 1 (id:??) landed as
https://crrev.com/7abe75523c7e774d534ec529146b86f6b25c05f3
Cr-Commit-Position: refs/heads/master@{#431309}