Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: samples/samples.status

Issue 2487363003: Re-enable Platform.executable under precompilation. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/platform.cc ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/samples.status
diff --git a/samples/samples.status b/samples/samples.status
index 22e755d9e5c3765efe5f93314f014138fa601cbb..fd8f58181f9ec7030aa77715233f35e498159959 100644
--- a/samples/samples.status
+++ b/samples/samples.status
@@ -23,5 +23,8 @@ sample_extension/test/sample_extension_app_snapshot_test: RuntimeError # Issue 2
[ $arch == arm ]
sample_extension/test/*: Skip # Issue 14705
-[ $noopt || $runtime == dart_precompiled || $runtime == dart_app ]
-sample_extension: Skip # Platform.executable
+[ $compiler == precompiler ]
+sample_extension/test/*: Skip # These tests attempt to spawn another script using the precompiled runtime.
+
+[ $runtime == dart_app ]
+sample_extension/test/*: Skip # Shared use of a temp directory
« no previous file with comments | « runtime/bin/platform.cc ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698