Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: runtime/bin/platform.cc

Issue 2487363003: Re-enable Platform.executable under precompilation. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | samples/samples.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/platform.cc
diff --git a/runtime/bin/platform.cc b/runtime/bin/platform.cc
index 15bfe3d2d45fe72b7600e3da9bfb4f229d70fe44..e8b7849147fff3ce403f356381af03ea9930b864 100644
--- a/runtime/bin/platform.cc
+++ b/runtime/bin/platform.cc
@@ -40,16 +40,6 @@ void FUNCTION_NAME(Platform_LocalHostname)(Dart_NativeArguments args) {
void FUNCTION_NAME(Platform_ExecutableName)(Dart_NativeArguments args) {
- if (Dart_IsPrecompiledRuntime()) {
- // This is a work-around to be able to use most of the existing test suite
- // for precompilation. Many tests do something like Process.run(
- // Platform.executable, some_other_script.dart). But with precompilation
- // the script is already fixed, so the spawned process runs the same script
- // again and we have a fork-bomb.
- Dart_ThrowException(Dart_NewStringFromCString(
- "Platform.executable not supported under precompilation"));
- UNREACHABLE();
- }
if (Platform::GetExecutableName() != NULL) {
Dart_SetReturnValue(
args, Dart_NewStringFromCString(Platform::GetExecutableName()));
@@ -60,12 +50,6 @@ void FUNCTION_NAME(Platform_ExecutableName)(Dart_NativeArguments args) {
void FUNCTION_NAME(Platform_ResolvedExecutableName)(Dart_NativeArguments args) {
- if (Dart_IsPrecompiledRuntime()) {
- Dart_ThrowException(Dart_NewStringFromCString(
- "Platform.resolvedExecutable not supported under precompilation"));
- UNREACHABLE();
- }
-
if (Platform::GetResolvedExecutableName() != NULL) {
Dart_SetReturnValue(
args, Dart_NewStringFromCString(Platform::GetResolvedExecutableName()));
« no previous file with comments | « no previous file | samples/samples.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698