Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2487363003: Re-enable Platform.executable under precompilation. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-enable Platform.executable under precompilation. Because the snapshot is passed explicitly, there is no longer the risk of a test that is valid running as a script becoming a fork-bomb when running as an AOT snapshot. Fixes #26417 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/646de0b77ed353abe9ae3d46a2259944b368d12d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -62 lines) Patch
M runtime/bin/platform.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M samples/samples.status View 1 1 chunk +5 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 chunks +43 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 1 month ago (2016-11-11 17:24:33 UTC) #3
siva
lgtm
4 years, 1 month ago (2016-11-11 23:46:35 UTC) #4
rmacnak
4 years, 1 month ago (2016-11-12 00:19:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
646de0b77ed353abe9ae3d46a2259944b368d12d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698