Add in-memory caching to PpdCache available printers.

Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755
Committed: https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a
Cr-Commit-Position: refs/heads/master@{#431641}

[Carlson, 2016-11-10 20:18:53]

justincarlson@chromium.org changed reviewers:
+ skau@chromium.org

[skau, 2016-11-10 20:46:38]

lgtm

some comment updates.  Also, please fill in the bug number.

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache.cc
File chromeos/printing/ppd_cache.cc (right):

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache...
chromeos/printing/ppd_cache.cc:256: // from disk or server), and remains for the
life of the PpdCache.
This isn't strictly true.  It's reset when the cached value expires.

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache.h
File chromeos/printing/ppd_cache.h (right):

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache...
chromeos/printing/ppd_cache.h:79: virtual const
PpdProvider::AvailablePrintersMap* FindAvailablePrinters() = 0;
Make a note of the expected lifetime of the map i.e. when, if ever, it's safe to
retain.

[Carlson, 2016-11-11 01:29:44]

Description was changed from

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=
==========

to

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755
==========

[Carlson, 2016-11-11 01:39:27]

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache.cc
File chromeos/printing/ppd_cache.cc (right):

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache...
chromeos/printing/ppd_cache.cc:256: // from disk or server), and remains for the
life of the PpdCache.
On 2016/11/10 20:46:37, skau wrote:
> This isn't strictly true.  It's reset when the cached value expires.

You're right, I changed this after I wrote the comment.  Fixed comment.

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache.h
File chromeos/printing/ppd_cache.h (right):

https://codereview.chromium.org/2487343006/diff/1/chromeos/printing/ppd_cache...
chromeos/printing/ppd_cache.h:79: virtual const
PpdProvider::AvailablePrintersMap* FindAvailablePrinters() = 0;
On 2016/11/10 20:46:37, skau wrote:
> Make a note of the expected lifetime of the map i.e. when, if ever, it's safe
to
> retain.

Done.

[Carlson, 2016-11-11 01:48:12]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2016-11-11 01:48:12]

The patchset sent to the CQ was uploaded after l-g-t-m from skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2487343006/#ps20001
(title: "Address skau comments")

[commit-bot: I haz the power, 2016-11-11 01:48:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:48:42]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Carlson, 2016-11-11 17:42:16]

justincarlson@chromium.org changed reviewers:
+ thestig@chromium.org

[Carlson, 2016-11-11 17:42:31]

Lei, would you mind taking a look?

[Lei Zhang, 2016-11-11 19:56:53]

On 2016/11/11 01:48:42, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

:-\ I nagged people about this.

[Lei Zhang, 2016-11-11 20:01:50]

lgtm

https://codereview.chromium.org/2487343006/diff/20001/chromeos/printing/ppd_c...
File chromeos/printing/ppd_cache.cc (right):

https://codereview.chromium.org/2487343006/diff/20001/chromeos/printing/ppd_c...
chromeos/printing/ppd_cache.cc:112: available_printers_.reset(new
PpdProvider::AvailablePrintersMap);
nit: Can you use MakeUnique instead?

available_printers_ = base::MakeUnique<PpdProvider::AvailablePrintersMap>();

[Carlson, 2016-11-11 20:26:42]

https://codereview.chromium.org/2487343006/diff/20001/chromeos/printing/ppd_c...
File chromeos/printing/ppd_cache.cc (right):

https://codereview.chromium.org/2487343006/diff/20001/chromeos/printing/ppd_c...
chromeos/printing/ppd_cache.cc:112: available_printers_.reset(new
PpdProvider::AvailablePrintersMap);
On 2016/11/11 20:01:50, Lei Zhang (slow) wrote:
> nit: Can you use MakeUnique instead?
> 
> available_printers_ = base::MakeUnique<PpdProvider::AvailablePrintersMap>();

Done.

[Carlson, 2016-11-11 20:26:47]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2016-11-11 20:26:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, skau@chromium.org
Link to the patchset: https://codereview.chromium.org/2487343006/#ps40001
(title: "Address thestig@ comment")

[commit-bot: I haz the power, 2016-11-11 20:27:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 21:00:55]

Description was changed from

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755
==========

to

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755
==========

[commit-bot: I haz the power, 2016-11-11 21:00:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 21:04:59]

Description was changed from

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755
==========

to

==========
Add in-memory caching to PpdCache available printers.

This should help make the printer make/model selection ui a little
more responsive.

BUG=662755

Committed: https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a
Cr-Commit-Position: refs/heads/master@{#431641}
==========

[commit-bot: I haz the power, 2016-11-11 21:05:00]

Patchset 3 (id:??) landed as
https://crrev.com/e845d5589dcc88bcfb1945c190bb47ca7d568c5a
Cr-Commit-Position: refs/heads/master@{#431641}