Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2909)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/threading/thread.cc

Issue 2487343005: Fix Thread::SetMessageLoop(nullptr). (Closed)
Patch Set: Merge up to r434093 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread.cc
diff --git a/base/threading/thread.cc b/base/threading/thread.cc
index 90b44f8e19a3263dc16769e373563193b095c467..ec2f98dd4b3484176ff4799369c1544cc1521b74 100644
--- a/base/threading/thread.cc
+++ b/base/threading/thread.cc
@@ -261,12 +261,7 @@ bool Thread::GetThreadWasQuitProperly() {
void Thread::SetMessageLoop(MessageLoop* message_loop) {
DCHECK(owning_sequence_checker_.CalledOnValidSequence());
-
- // TODO(gab): Figure out why some callers pass in a null |message_loop|...
- // https://crbug.com/629139#c15
- // DCHECK(message_loop);
- if (!message_loop)
- return;
+ DCHECK(message_loop);
// Setting |message_loop_| should suffice for this thread to be considered
// as "running", until Stop() is invoked.
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698