Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 2487333002: Reenable Cronet tests. (Closed)

Created:
4 years, 1 month ago by Bence
Modified:
4 years, 1 month ago
Reviewers:
timvolodine, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, xunjieli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable Cronet tests. Tests broke because of https://crrev.com/2461683002. Tests were fixed at https://crrev.com/2484863010. Independently, tests were disabled at https://crrev.com/2489793003. As tests were fixed, it is safe to re-enable them. BUG=663789 Committed: https://crrev.com/8d2f734c5df7942278ea1e68ac1fa86877afd146 Cr-Commit-Position: refs/heads/master@{#431050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Bence
timvolodine: PTAL. Thank you.
4 years, 1 month ago (2016-11-09 21:54:40 UTC) #4
xunjieli
LGTM (I am rubberstamping this since you might need an OWNER stamp.)
4 years, 1 month ago (2016-11-09 21:56:35 UTC) #6
Bence
On 2016/11/09 21:56:35, xunjieli wrote: > LGTM > (I am rubberstamping this since you might ...
4 years, 1 month ago (2016-11-09 22:00:04 UTC) #7
xunjieli
Right, you either need an OWNER stamp or TBR this change. On Wed, Nov 9, ...
4 years, 1 month ago (2016-11-09 22:04:11 UTC) #10
Bence
On 2016/11/09 22:04:11, xunjieli wrote: > Right, you either need an OWNER stamp or TBR ...
4 years, 1 month ago (2016-11-09 22:05:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487333002/1
4 years, 1 month ago (2016-11-09 22:09:43 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 22:16:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 22:24:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d2f734c5df7942278ea1e68ac1fa86877afd146
Cr-Commit-Position: refs/heads/master@{#431050}

Powered by Google App Engine
This is Rietveld 408576698