Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2487323002:
Fix crash upon opening print preview with invalid printer. (Closed)
DescriptionFix crash upon opening print preview with invalid printer.
If a printer doesn't have a PPD, print preview is currently crashing
due to a segfault. Check for the nullptr.
BUG=663679
TEST=Select a printer without a PPD in Linux. Verify print preview
doesn't crash
Committed: https://crrev.com/239bf3134b00d347e9a9f39354c1646ced1f68fc
Cr-Commit-Position: refs/heads/master@{#431051}
Patch Set 1 #Patch Set 2 : fallback #
Total comments: 2
Patch Set 3 : nit #Messages
Total messages: 19 (10 generated)
The CQ bit was checked by skau@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I overlooked a null check. I've verified that it should work now. Problem occurs when opening a printer without a PPD in which case we should revert to "Save as PDF".
skau@chromium.org changed reviewers: + thestig@chromium.org
thestig@ PTAL
lgtm https://codereview.chromium.org/2487323002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/print_preview/printer_capabilities.cc (right): https://codereview.chromium.org/2487323002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/print_preview/printer_capabilities.cc:29: // |nullptr| if a dictionary could not be generated. nit: nullptr is not the name of a variable.
The CQ bit was checked by skau@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2487323002/#ps40001 (title: "nit")
Thanks. https://codereview.chromium.org/2487323002/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/print_preview/printer_capabilities.cc (right): https://codereview.chromium.org/2487323002/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/print_preview/printer_capabilities.cc:29: // |nullptr| if a dictionary could not be generated. On 2016/11/09 21:29:17, Lei Zhang (slow) wrote: > nit: nullptr is not the name of a variable. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Oh, bug # is wrong. I will edit.
Description was changed from ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=63679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash ========== to ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=663679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash ==========
The CQ bit was unchecked by thestig@chromium.org
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=663679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash ========== to ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=663679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=663679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash ========== to ========== Fix crash upon opening print preview with invalid printer. If a printer doesn't have a PPD, print preview is currently crashing due to a segfault. Check for the nullptr. BUG=663679 TEST=Select a printer without a PPD in Linux. Verify print preview doesn't crash Committed: https://crrev.com/239bf3134b00d347e9a9f39354c1646ced1f68fc Cr-Commit-Position: refs/heads/master@{#431051} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/239bf3134b00d347e9a9f39354c1646ced1f68fc Cr-Commit-Position: refs/heads/master@{#431051} |
