Evict using size in bytes in MemoryCachingByteStore.

Evict using size in bytes in MemoryCachingByteStore.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/050e16d2218ba5aed08cd2bf98455fe7ebc0ae6c

[Brian Wilkerson, 2016-11-09 20:15:58]

lgtm

[Paul Berry, 2016-11-09 20:17:37]

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/byte_store.dart (right):

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/byte_store.dart:39: final HashMap<String,
List<int>> _map = new HashMap<String, List<int>>();
Why change this to a HashMap?  Don't we lose the "least recently used" behavior
we want?

[scheglov, 2016-11-09 20:21:33]

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/byte_store.dart (right):

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/byte_store.dart:39: final HashMap<String,
List<int>> _map = new HashMap<String, List<int>>();
On 2016/11/09 20:17:36, Paul Berry wrote:
> Why change this to a HashMap?  Don't we lose the "least recently used"
behavior
> we want?

Ouch.
Thanks.
That's a mistake.
Fixed.

[Paul Berry, 2016-11-09 20:22:15]

lgtm

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/byte_store.dart (right):

https://codereview.chromium.org/2487313002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/byte_store.dart:39: final HashMap<String,
List<int>> _map = new HashMap<String, List<int>>();
On 2016/11/09 20:21:33, scheglov wrote:
> On 2016/11/09 20:17:36, Paul Berry wrote:
> > Why change this to a HashMap?  Don't we lose the "least recently used"
> behavior
> > we want?
> 
> Ouch.
> Thanks.
> That's a mistake.
> Fixed.

Ok, with that fixed, lgtm.

[scheglov, 2016-11-09 20:22:37]

Description was changed from

==========
Evict using size in bytes in MemoryCachingByteStore.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Evict using size in bytes in MemoryCachingByteStore.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/050e16d2218ba5aed08cd2bf98455fe7ebc0ae6c
==========

[scheglov, 2016-11-09 20:22:38]

Committed patchset #2 (id:20001) manually as
050e16d2218ba5aed08cd2bf98455fe7ebc0ae6c (presubmit successful).