Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2487303002: Added comment about using fixed-size objects when data could be passed between different CPU archit… (Closed)

Created:
4 years, 1 month ago by bcwhite
Modified:
4 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added comment about using fixed-size objects when data could be passed between different CPU architectures. BUG= Committed: https://crrev.com/e99be2d93be12025779ab63f74e0a96560ed0a0b Cr-Commit-Position: refs/heads/master@{#431010}

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/metrics/persistent_memory_allocator.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bcwhite
4 years, 1 month ago (2016-11-09 18:26:36 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/2487303002/diff/1/base/metrics/persistent_memory_allocator.h File base/metrics/persistent_memory_allocator.h (right): https://codereview.chromium.org/2487303002/diff/1/base/metrics/persistent_memory_allocator.h#newcode232 base/metrics/persistent_memory_allocator.h:232: // (u)intXX_t. Unacceptable are int, bool, or wchar_t ...
4 years, 1 month ago (2016-11-09 18:30:19 UTC) #5
bcwhite
https://codereview.chromium.org/2487303002/diff/1/base/metrics/persistent_memory_allocator.h File base/metrics/persistent_memory_allocator.h (right): https://codereview.chromium.org/2487303002/diff/1/base/metrics/persistent_memory_allocator.h#newcode232 base/metrics/persistent_memory_allocator.h:232: // (u)intXX_t. Unacceptable are int, bool, or wchar_t which ...
4 years, 1 month ago (2016-11-09 18:45:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487303002/20001
4 years, 1 month ago (2016-11-09 18:46:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-09 19:40:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 19:44:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e99be2d93be12025779ab63f74e0a96560ed0a0b
Cr-Commit-Position: refs/heads/master@{#431010}

Powered by Google App Engine
This is Rietveld 408576698