Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2487273002: [No submit][SPInvalidation] Track paint offset change (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 7809718197662d42c7d098da2a81de3594935373..d618961420c67b613eecb2a7c3aa07c49fbf4cae 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -226,6 +226,7 @@ void PaintPropertyTreeBuilder::updatePaintOffsetTranslation(
const auto* properties = object.paintProperties();
if (properties && properties->paintOffsetTranslation()) {
+ LOG(ERROR) << object.debugName() << " created paintOffsetTranslation";
context.current.transform = properties->paintOffsetTranslation();
context.current.paintOffset = fractionalPaintOffset;
if (RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
@@ -236,6 +237,9 @@ void PaintPropertyTreeBuilder::updatePaintOffsetTranslation(
context.fixedPosition.paintOffset = LayoutPoint();
}
}
+
+ LOG(ERROR) << object.debugName()
+ << " paintOffset:" << context.current.paintOffset.toString();
}
static FloatPoint3D transformOrigin(const LayoutBox& box) {
@@ -666,6 +670,8 @@ void PaintPropertyTreeBuilder::updateOutOfFlowContext(
if (object.canContainAbsolutePositionObjects()) {
context.absolutePosition = context.current;
context.containerForAbsolutePosition = &object;
+ LOG(ERROR) << object.debugName() << " canContainAbsolute: paintOffset="
+ << context.absolutePosition.paintOffset.toString();
}
if (object.isLayoutView()) {
@@ -821,8 +827,12 @@ static void deriveBorderBoxFromContainerContext(
// calculate containers (e.g., topLeftLocation, offsetForInFlowPosition*).
// The containing block and other containers can be stored on
// PaintPropertyTreeBuilderContext instead of recomputing them.
+ LOG(ERROR) << object.debugName() << " before offset paintOffset="
+ << context.current.paintOffset.toString();
context.current.paintOffset.moveBy(
toLayoutBox(boxModelObject).topLeftLocation());
+ LOG(ERROR) << object.debugName() << " add offset paintOffset="
+ << context.current.paintOffset.toString();
// This is a weird quirk that table cells paint as children of table rows,
// but their location have the row's location baked-in.
// Similar adjustment is done in LayoutTableCell::offsetFromContainer().
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintInvalidator.cpp ('k') | third_party/WebKit/Source/core/paint/PartPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698