[No submit][SPInvalidation] Track paint offset change

third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintInvalidator.h"
 
 #include "core/editing/FrameSelection.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
@@ skipping 174 matching lines @@
     point.moveBy(-containerContentsProperties.paintOffset);
   }
 
   if (context.paintInvalidationContainer->layer()->groupedMapping())
     PaintLayer::mapPointInPaintInvalidationContainerToBacking(
         *context.paintInvalidationContainer, point);
 
   return LayoutPoint(point);
 }
 
+static LayoutPoint computePaintOffset(const LayoutObject& object,
+                                      PaintInvalidatorContext& context) {
+  LayoutPoint paintOffset = context.treeBuilderContext.current.paintOffset;
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    return paintOffset;
+
+  if (object.isSVG() && !object.isSVGRoot())
+    return paintOffset;
+
+  if (object.isLayoutView() ||
+      (object.hasLayer() &&
+       toLayoutBoxModelObject(object).layer()->paintsWithTransform(
+           GlobalPaintNormalPhase))) {
+    if (object != context.paintInvalidationContainer) {
+      context.shouldAdjustPaintOffsetToContainer = false;
+      LOG(ERROR) << "reset shouldAdjustToContainer by " << object.debugName();
+    }
+    if (object != context.paintInvalidationContainerForStackedContents) {
+      LOG(ERROR) << "reset shouldAdjustToContainerForStackedContents by "
+                 << object.debugName();
+      context.shouldAdjustPaintOffsetToContainerForStackedContents = false;
+    }
+  }
+
+  if (context.shouldAdjustPaintOffsetToContainer) {
+    LOG(ERROR) << object.debugName() << " adjust paint offset to "
+               << context.paintInvalidationContainer->debugName()
+               << " paint offset=" << paintOffset.toString();
+    paintOffset -= toIntSize(
+        roundedIntPoint(context.paintInvalidationContainer->paintProperties()
+                            ->localBorderBoxProperties()
+                            ->paintOffset));
+    LOG(ERROR) << "  after adjustment=" << paintOffset.toString();
+  }
+  if (object != context.paintInvalidationContainer &&
+      context.paintInvalidationContainer->usesCompositedScrolling()) {
+    const LayoutBox* box = toLayoutBox(context.paintInvalidationContainer);
+    if (box->hasOverflowClip())
+      paintOffset += box->scrolledContentOffset();
+    LOG(ERROR) << "  after adjustment for scroll offset="
+               << paintOffset.toString();
+  }
+  return paintOffset;
+}
+
 void PaintInvalidator::updatePaintingLayer(const LayoutObject& object,
                                            PaintInvalidatorContext& context) {
   if (object.hasLayer() &&
       toLayoutBoxModelObject(object).hasSelfPaintingLayer())
     context.paintingLayer = toLayoutBoxModelObject(object).layer();
 
   if (object.isLayoutBlockFlow() && toLayoutBlockFlow(object).containsFloats())
     context.paintingLayer->setNeedsPaintPhaseFloat();
 
   if (object == context.paintingLayer->layoutObject())
@@ skipping 52 matching lines @@
 
 }  // namespace
 
 void PaintInvalidator::updateContext(const LayoutObject& object,
                                      PaintInvalidatorContext& context) {
   Optional<ScopedUndoFrameViewContentClipAndScroll>
       undoFrameViewContentClipAndScroll;
 
   if (object.isPaintInvalidationContainer()) {
     context.paintInvalidationContainer = toLayoutBoxModelObject(&object);
-    if (object.styleRef().isStackingContext())
+    context.shouldAdjustPaintOffsetToContainer = true;
+    if (object.styleRef().isStackingContext()) {
       context.paintInvalidationContainerForStackedContents =
           toLayoutBoxModelObject(&object);
+      context.shouldAdjustPaintOffsetToContainerForStackedContents = true;
+    }
   } else if (object.isLayoutView()) {
     // paintInvalidationContainerForStackedContents is only for stacked
     // descendants in its own frame, because it doesn't establish stacking
     // context for stacked contents in sub-frames.
     // Contents stacked in the root stacking context in this frame should use
     // this frame's paintInvalidationContainer.
     context.paintInvalidationContainerForStackedContents =
         context.paintInvalidationContainer;
+    context.shouldAdjustPaintOffsetToContainerForStackedContents =
+        context.shouldAdjustPaintOffsetToContainer;
     if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
       undoFrameViewContentClipAndScroll.emplace(
           *toLayoutView(object).frameView(), context);
   } else if (object.styleRef().isStacked() &&
              // This is to exclude some objects (e.g. LayoutText) inheriting
              // stacked style from parent but aren't actually stacked.
              object.hasLayer() &&
              context.paintInvalidationContainer !=
                  context.paintInvalidationContainerForStackedContents) {
     // The current object is stacked, so we should use
     // m_paintInvalidationContainerForStackedContents as its paint invalidation
     // container on which the current object is painted.
     context.paintInvalidationContainer =
         context.paintInvalidationContainerForStackedContents;
+    context.shouldAdjustPaintOffsetToContainer =
+        context.shouldAdjustPaintOffsetToContainerForStackedContents;
     if (context.forcedSubtreeInvalidationFlags &
         PaintInvalidatorContext::
-            ForcedSubtreeFullInvalidationForStackedContents)
+            ForcedSubtreeFullInvalidationForStackedContents) {
       context.forcedSubtreeInvalidationFlags |=
           PaintInvalidatorContext::ForcedSubtreeFullInvalidation;
+    }
   }
 
   if (object == context.paintInvalidationContainer) {
     // When we hit a new paint invalidation container, we don't need to
     // continue forcing a check for paint invalidation, since we're
     // descending into a different invalidation container. (For instance if
     // our parents were moved, the entire container will just move.)
     if (object != context.paintInvalidationContainerForStackedContents) {
       // However, we need to keep the
       // ForcedSubtreeFullInvalidationForStackedContents flag if the current
@@ skipping 16 matching lines @@
   // TODO(crbug.com/637313): This is temporary before we support filters in
   // paint property tree.
   // TODO(crbug.com/648274): This is a workaround for multi-column contents.
   if (object.hasFilterInducingProperty() || object.isLayoutFlowThread())
     context.forcedSubtreeInvalidationFlags |=
         PaintInvalidatorContext::ForcedSubtreeSlowPathRect;
 
   ObjectPaintInvalidator objectPaintInvalidator(object);
   context.oldVisualRect = object.previousVisualRect();
   context.oldLocation = objectPaintInvalidator.previousLocationInBacking();
+  context.oldPaintOffset = object.previousPaintOffset();
   context.newVisualRect = computeVisualRectInBacking(object, context);
   context.newLocation = computeLocationInBacking(object, context);
+  context.newPaintOffset = computePaintOffset(object, context);
 
   IntSize adjustment = object.scrollAdjustmentForPaintInvalidation(
       *context.paintInvalidationContainer);
   context.newLocation.move(adjustment);
   context.newVisualRect.move(adjustment);
 
   object.getMutableForPainting().setPreviousVisualRect(context.newVisualRect);
+  object.getMutableForPainting().setPreviousPaintOffset(context.newPaintOffset);
   objectPaintInvalidator.setPreviousLocationInBacking(context.newLocation);
 }
 
 void PaintInvalidator::invalidatePaintIfNeeded(
     FrameView& frameView,
     PaintInvalidatorContext& context) {
   LayoutView* layoutView = frameView.layoutView();
   CHECK(layoutView);
 
   context.paintInvalidationContainer =
       context.paintInvalidationContainerForStackedContents =
           &layoutView->containerForPaintInvalidation();
+  context.shouldAdjustPaintOffsetToContainer =
+      context.shouldAdjustPaintOffsetToContainerForStackedContents = true;
   context.paintingLayer = layoutView->layer();
 
   if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
     ScopedUndoFrameViewContentClipAndScroll undo(frameView, context);
     frameView.invalidatePaintOfScrollControlsIfNeeded(context);
   }
 
   if (frameView.frame().selection().isCaretBoundsDirty())
     frameView.frame().selection().invalidateCaretRect();
 
   // Temporary callback for crbug.com/487345,402044
   // TODO(ojan): Make this more general to be used by PositionObserver
   // and rAF throttling.
   IntRect visibleRect =
       frameView.rootFrameToContents(frameView.computeVisibleArea());
   layoutView->sendMediaPositionChangeNotifications(visibleRect);
 }
 
-static bool hasPercentageTransform(const ComputedStyle& style) {
-  if (TransformOperation* translate = style.translate()) {
-    if (translate->dependsOnBoxSize())
-      return true;
-  }
-  return style.transform().dependsOnBoxSize() ||
-         (style.transformOriginX() != Length(50, Percent) &&
-          style.transformOriginX().isPercentOrCalc()) ||
-         (style.transformOriginY() != Length(50, Percent) &&
-          style.transformOriginY().isPercentOrCalc());
-}
-
 void PaintInvalidator::invalidatePaintIfNeeded(
     const LayoutObject& object,
     PaintInvalidatorContext& context) {
   object.getMutableForPainting().ensureIsReadyForPaintInvalidation();
 
   if (!context.forcedSubtreeInvalidationFlags &&
       !object
            .shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState())
     return;
 
@@ skipping 29 matching lines @@
                ForcedSubtreeFullInvalidationForStackedContents);
       break;
     case PaintInvalidationSVGResourceChange:
       context.forcedSubtreeInvalidationFlags |=
           PaintInvalidatorContext::ForcedSubtreeSVGResourceChange;
       break;
     default:
       break;
   }
 
-  if (context.oldLocation != context.newLocation)
+  if (context.oldLocation != context.newLocation ||
+      context.oldPaintOffset != context.newPaintOffset) {
     context.forcedSubtreeInvalidationFlags |=
         PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
-
-  // TODO(crbug.com/533277): This is a workaround for the bug. Remove when we
-  // detect paint offset change.
-  if (reason != PaintInvalidationNone &&
-      hasPercentageTransform(object.styleRef()))
-    context.forcedSubtreeInvalidationFlags |=
-        PaintInvalidatorContext::ForcedSubtreeInvalidationChecking;
+  }
 
   // TODO(crbug.com/490725): This is a workaround for the bug, to force
   // descendant to update visual rects on clipping change.
   if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
       context.oldVisualRect != context.newVisualRect
       // Note that isLayoutView() below becomes unnecessary after the launch of
       // root layer scrolling.
       && (object.hasOverflowClip() || object.isLayoutView()) &&
       !toLayoutBox(object).usesCompositedScrolling())
     context.forcedSubtreeInvalidationFlags |=
         PaintInvalidatorContext::ForcedSubtreeInvalidationRectUpdate;
 
   object.getMutableForPainting().clearPaintInvalidationFlags();
 }
 
 void PaintInvalidator::processPendingDelayedPaintInvalidations() {
   for (auto target : m_pendingDelayedPaintInvalidations)
     target->getMutableForPainting().setShouldDoFullPaintInvalidation(
         PaintInvalidationDelayedFull);
 }
 
 }  // namespace blink