Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/test/data/push_messaging/service_worker.js

Issue 2487233002: Handle push resubscribes with no sender info (avoids DCHECK) (Closed)
Patch Set: Handle push resubscribes with no sender info (avoids DCHECK) Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/push_messaging/push_test.js ('k') | chrome/test/data/push_messaging/test_no_manifest.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/push_messaging/service_worker.js
diff --git a/chrome/test/data/push_messaging/service_worker.js b/chrome/test/data/push_messaging/service_worker.js
index f32068849a8fb2b3995e84fd895d82133efc97a0..5cc3db846dbc1ca079ddcc74aaf8b5fddcc52b41 100644
--- a/chrome/test/data/push_messaging/service_worker.js
+++ b/chrome/test/data/push_messaging/service_worker.js
@@ -49,6 +49,9 @@ this.onpush = function(event) {
self.addEventListener('message', function handler (event) {
if (event.data.command == 'workerSubscribe') {
pushSubscriptionOptions.applicationServerKey = kApplicationServerKey.buffer;
+ } else if (event.data.command == 'workerSubscribeWithNumericKey') {
+ pushSubscriptionOptions.applicationServerKey =
+ new TextEncoder().encode('1234567890');
} else if (event.data.command == 'workerSubscribeNoKey') {
// Nothing to set up
} else {
« no previous file with comments | « chrome/test/data/push_messaging/push_test.js ('k') | chrome/test/data/push_messaging/test_no_manifest.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698