Issue 2487183002: VM: [Kernel] Ensure we have the correct try-index when translating finally blocks

Issue 2487183002: VM: [Kernel] Ensure we have the correct try-index when translating finally blocks (Closed)

Created:
4 years, 1 month ago by kustermann

Modified:
4 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google), Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: [Kernel] Ensure we have the correct try-index when translating finally blocks BUG=https://github.com/dart-lang/kernel_sdk/issues/25 R=kmillikin@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/a8f87725eb8984d9a4f99259ac381195a16469db

Patch Set 2 : Fixed two issues #

Patch Set 3 : Rebased & remove print in test #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -5 lines)			Patch
	M	runtime/vm/kernel_to_il.cc	View	1 2	9 chunks	+25 lines, -5 lines	0 comments	Download
	M	tests/kernel/unsorted/try_finally_test.dart	View	1 2	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kevin Millikin (Google)

LGTM. https://codereview.chromium.org/2487183002/diff/1/runtime/vm/kernel_to_il.cc File runtime/vm/kernel_to_il.cc (right): https://codereview.chromium.org/2487183002/diff/1/runtime/vm/kernel_to_il.cc#newcode857 runtime/vm/kernel_to_il.cc:857: intptr_t try_index() const { return try_depth_; } return ...

4 years, 1 month ago (2016-11-09 12:30:03 UTC) #3

kustermann

Committed patchset #3 (id:40001) manually as a8f87725eb8984d9a4f99259ac381195a16469db (presubmit successful).

4 years, 1 month ago (2016-11-11 19:38:55 UTC) #6

kustermann

4 years, 1 month ago (2016-11-11 19:41:35 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/2487183002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2487183002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:857: intptr_t try_index() const { return try_depth_;
}
On 2016/11/09 12:30:02, Kevin Millikin (Google) wrote:
> return try_index_

Thanks for catching this! I've modified the test to also hit this part.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages