Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: chrome/browser/download/download_status_updater_unittest.cc

Issue 248713004: [Downloads] Add real observers to MockDownloadItem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with r268551 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_status_updater_unittest.cc
diff --git a/chrome/browser/download/download_status_updater_unittest.cc b/chrome/browser/download/download_status_updater_unittest.cc
index 05410a6f09b5e9d541d61aa962c589dcf9080c64..a1df7b9997ada5e1c27af53e44ebdb7d708d9c1f 100644
--- a/chrome/browser/download/download_status_updater_unittest.cc
+++ b/chrome/browser/download/download_status_updater_unittest.cc
@@ -54,10 +54,6 @@ class DownloadStatusUpdaterTest : public testing::Test {
virtual ~DownloadStatusUpdaterTest() {
for (size_t mgr_idx = 0; mgr_idx < managers_.size(); ++mgr_idx) {
EXPECT_CALL(*Manager(mgr_idx), RemoveObserver(_));
- for (size_t item_idx = 0; item_idx < manager_items_[mgr_idx].size();
- ++item_idx) {
- EXPECT_CALL(*Item(mgr_idx, item_idx), RemoveObserver(_));
- }
}
delete updater_;
@@ -116,8 +112,6 @@ class DownloadStatusUpdaterTest : public testing::Test {
i < in_progress_count ? content::DownloadItem::IN_PROGRESS
: content::DownloadItem::CANCELLED;
EXPECT_CALL(*item, GetState()).WillRepeatedly(Return(state));
- EXPECT_CALL(*item, AddObserver(_))
- .WillOnce(Return());
manager_items_[manager_index].push_back(item);
}
EXPECT_CALL(*manager, GetAllDownloads(_))

Powered by Google App Engine
This is Rietveld 408576698