Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: chrome/browser/download/all_download_item_notifier_unittest.cc

Issue 248713004: [Downloads] Add real observers to MockDownloadItem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/all_download_item_notifier_unittest.cc
diff --git a/chrome/browser/download/all_download_item_notifier_unittest.cc b/chrome/browser/download/all_download_item_notifier_unittest.cc
index 453feba75f799be7ceaeade10b032ec2e95b8f0b..99d0f58a858dd5dad2f54cdfea1e5261a1c74ec4 100644
--- a/chrome/browser/download/all_download_item_notifier_unittest.cc
+++ b/chrome/browser/download/all_download_item_notifier_unittest.cc
@@ -85,7 +85,6 @@ TEST_F(AllDownloadItemNotifierTest,
items.push_back(&item());
EXPECT_CALL(manager(), GetAllDownloads(_))
.WillOnce(SetArgPointee<0>(items));
- EXPECT_CALL(item(), AddObserver(_));
SetNotifier();
EXPECT_CALL(observer(), OnDownloadUpdated(&manager(), &item()));
@@ -97,7 +96,6 @@ TEST_F(AllDownloadItemNotifierTest,
EXPECT_CALL(observer(), OnDownloadRemoved(&manager(), &item()));
NotifierAsItemObserver()->OnDownloadRemoved(&item());
- EXPECT_CALL(item(), RemoveObserver(NotifierAsItemObserver()));
EXPECT_CALL(manager(), RemoveObserver(NotifierAsManagerObserver()));
ClearNotifier();
}
@@ -107,7 +105,6 @@ TEST_F(AllDownloadItemNotifierTest,
EXPECT_CALL(manager(), GetAllDownloads(_));
SetNotifier();
- EXPECT_CALL(item(), AddObserver(NotifierAsItemObserver()));
EXPECT_CALL(observer(), OnDownloadCreated(&manager(), &item()));
NotifierAsManagerObserver()->OnDownloadCreated(
&manager(), &item());
@@ -115,8 +112,5 @@ TEST_F(AllDownloadItemNotifierTest,
EXPECT_CALL(manager(), RemoveObserver(NotifierAsManagerObserver()));
NotifierAsManagerObserver()->ManagerGoingDown(&manager());
- EXPECT_CALL(item(), RemoveObserver(NotifierAsItemObserver()));
- NotifierAsItemObserver()->OnDownloadDestroyed(&item());
-
ClearNotifier();
}

Powered by Google App Engine
This is Rietveld 408576698