Temporarily mark Maps.maps_004 flaky on Mac and Win.

Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true

Committed: https://crrev.com/ed9e7b5e2ed9df6f02ea4638523b2da65a59a8ba
Cr-Commit-Position: refs/heads/master@{#430984}

[Ken Russell (switch to Gerrit), 2016-11-09 18:22:15]

Description was changed from

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
==========

to

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-09 18:22:25]

kbr@chromium.org changed reviewers:
+ vmiura@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-09 18:22:49]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-09 18:22:50]

FYI. CQ'ing TBR'd and NOTRY. Tested locally.

[Ken Russell (switch to Gerrit), 2016-11-09 18:23:02]

Description was changed from

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true
==========

[Ken Russell (switch to Gerrit), 2016-11-09 18:23:05]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-09 18:23:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 18:28:56]

Description was changed from

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true
==========

to

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-09 18:28:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-09 18:47:00]

Description was changed from

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true
==========

to

==========
Temporarily mark Maps.maps_004 flaky on Mac and Win.

Revert commit 8cf7cb095499c4627228940c2ab0d07aba839d4f, which was not
the correct way of performing this disable.

BUG=626986
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=vmiura@chromium.org,zmo@chromium.org
NOTRY=true

Committed: https://crrev.com/ed9e7b5e2ed9df6f02ea4638523b2da65a59a8ba
Cr-Commit-Position: refs/heads/master@{#430984}
==========

[commit-bot: I haz the power, 2016-11-09 18:47:01]

Patchset 1 (id:??) landed as
https://crrev.com/ed9e7b5e2ed9df6f02ea4638523b2da65a59a8ba
Cr-Commit-Position: refs/heads/master@{#430984}

[vabr (Chromium), 2016-11-10 08:10:19]

On 2016/11/09 18:47:01, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ed9e7b5e2ed9df6f02ea4638523b2da65a59a8ba
> Cr-Commit-Position: refs/heads/master@{#430984}

Thanks for fixing this, Ken!

Is there any documentation for disabling these kinds of tests?

Cheers,
Vaclav

[Ken Russell (switch to Gerrit), 2016-11-10 23:16:36]

On 2016/11/10 08:10:19, vabr (Chromium) wrote:
> On 2016/11/09 18:47:01, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/ed9e7b5e2ed9df6f02ea4638523b2da65a59a8ba
> > Cr-Commit-Position: refs/heads/master@{#430984}
> 
> Thanks for fixing this, Ken!
> 
> Is there any documentation for disabling these kinds of tests?
> 
> Cheers,
> Vaclav

Hi Vaclav,

No problem and sorry for the difficulty. As you've seen on crbug.com/626986,
we're still trying to figure out what changed to cause this test to become
flaky.

Documentation on disabling these tests is in the section "WebGL conformance
tests or other GPU tests" on:
https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium

and also in the step "Update Telemetry-based test expectations if necessary" on:
http://www.chromium.org/developers/how-tos/gpu-wrangling#TOC-How-to-Keep-the-...