Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2487073003: Update legacycaller FIXMEs to reflect spec changes (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update legacycaller FIXMEs to reflect spec changes legacycaller has been dropped for all but HTMLAllCollection in HTML: https://github.com/whatwg/html/pull/203 https://github.com/whatwg/html/pull/1979 BUG=465009, 663662 R=tkent@chromium.org Committed: https://crrev.com/7bca5aabd14fb747ef1cfa083d181ec933707e7c Cr-Commit-Position: refs/heads/master@{#431535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/HTMLAllCollection.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.idl View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
foolip
4 years, 1 month ago (2016-11-09 09:46:08 UTC) #1
tkent
lgtm
4 years, 1 month ago (2016-11-11 00:16:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487073003/1
4 years, 1 month ago (2016-11-11 00:17:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/329841)
4 years, 1 month ago (2016-11-11 03:18:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487073003/1
4 years, 1 month ago (2016-11-11 09:18:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 10:31:26 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 10:33:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bca5aabd14fb747ef1cfa083d181ec933707e7c
Cr-Commit-Position: refs/heads/master@{#431535}

Powered by Google App Engine
This is Rietveld 408576698