chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 2487043002: Refine braille output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 2487043002: Refine braille output (Closed)

Patch Set: Refine braille output Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 72810d1ec6e51430e547dfa0a3142fc1ab118c79..79e5f8fb9dc57c9703e9466a8aa2562868a73f06 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -664,7 +664,7 @@ Background.prototype = {

actionNode.doDefault();

if (selectionSpan) {

var start = text.getSpanStart(selectionSpan);

- var targetPosition = position - start + selectionSpan.offset;

+ var targetPosition = position - start;

actionNode.setSelection(targetPosition, targetPosition);

}