Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 248703002: Remove ContentClient::CanHandleWhileSwappedOut(). (Closed)

Created:
6 years, 8 months ago by Sungmann Cho
Modified:
6 years, 7 months ago
Reviewers:
joth, jam, boliu, jabdelmalek
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove ContentClient::CanHandleWhileSwappedOut(). According to the issue 265021, ContentClient::CanHandleWhileSwappedOut() was introduced to support synchronous browser->renderer messages for WebView. But this is now obsolete, so we can remove it. BUG=265021 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M chrome/common/chrome_content_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/common/content_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
Sungmann Cho
Please take a look. Thanks.
6 years, 8 months ago (2014-04-23 03:43:20 UTC) #1
joth
Nice. patch looks good to me. thanks! You need to sign the CLA as per ...
6 years, 8 months ago (2014-04-23 04:02:28 UTC) #2
Sungmann Cho
Thank you Joth! And I've already signed the CLA.
6 years, 8 months ago (2014-04-23 04:17:22 UTC) #3
joth
On 22 April 2014 21:17, <sungmann.cho@navercorp.com> wrote: > Thank you Joth! And I've already signed ...
6 years, 8 months ago (2014-04-23 04:50:54 UTC) #4
Sungmann Cho
I don’t think so. I’ve signed the CLA with sungmann.cho@navercorp.com and it exists in AUTHORS. ...
6 years, 8 months ago (2014-04-23 05:15:56 UTC) #5
joth
OK. I see a gmail address (twice) and @nhn.com -- but looks like nhn.com is ...
6 years, 8 months ago (2014-04-23 05:23:02 UTC) #6
Sungmann Cho
On 2014/04/23 05:23:02, joth (inactive) wrote: > OK. I see a gmail address (twice) and ...
6 years, 8 months ago (2014-04-23 05:28:44 UTC) #7
joth
From http://dev.chromium.org/developers/contributing-code/external-contributor-checklistit says: "If there's an entry for the right name, but a different email ...
6 years, 8 months ago (2014-04-23 16:42:18 UTC) #8
Sungmann Cho
On 2014/04/23 16:42:18, joth (inactive) wrote: > From > http://dev.chromium.org/developers/contributing-code/external-contributor-checklistit > says: > "If there's ...
6 years, 8 months ago (2014-04-23 17:45:48 UTC) #9
joth
lgtm
6 years, 8 months ago (2014-04-23 17:59:22 UTC) #10
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 8 months ago (2014-04-23 20:45:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/248703002/1
6 years, 8 months ago (2014-04-23 20:46:22 UTC) #12
boliu
I was dropped from this thread (or never added?) Looks like joth took care of ...
6 years, 8 months ago (2014-04-23 20:47:53 UTC) #13
Sungmann Cho
The CQ bit was unchecked by sungmann.cho@navercorp.com
6 years, 8 months ago (2014-04-23 20:53:29 UTC) #14
Sungmann Cho
On 2014/04/23 20:47:53, boliu wrote: > I was dropped from this thread (or never added?) ...
6 years, 8 months ago (2014-04-24 00:39:31 UTC) #15
Sungmann Cho
jam@ please take a look.
6 years, 8 months ago (2014-04-24 00:43:37 UTC) #16
Sungmann Cho
ping...
6 years, 8 months ago (2014-04-26 01:41:12 UTC) #17
Sungmann Cho
ping...
6 years, 7 months ago (2014-04-29 05:01:53 UTC) #18
Sungmann Cho
ping...
6 years, 7 months ago (2014-05-01 20:53:46 UTC) #19
boliu
Maybe ask jam on irc?
6 years, 7 months ago (2014-05-01 20:55:20 UTC) #20
Sungmann Cho
On 2014/05/01 20:55:20, boliu wrote: > Maybe ask jam on irc? OK. Thanks! :)
6 years, 7 months ago (2014-05-01 21:39:33 UTC) #21
jabdelmalek
On 2014/05/01 21:39:33, Sungmann Cho wrote: > On 2014/05/01 20:55:20, boliu wrote: > > Maybe ...
6 years, 7 months ago (2014-05-02 23:38:46 UTC) #22
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-03 00:45:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/248703002/1
6 years, 7 months ago (2014-05-03 00:46:16 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 00:59:44 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-03 00:59:44 UTC) #26
boliu
jam@ You used your google.com account...maybe it's ok to tbr now
6 years, 7 months ago (2014-05-03 01:32:21 UTC) #27
jam
sorry, lgtm from this account
6 years, 7 months ago (2014-05-05 15:34:00 UTC) #28
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 7 months ago (2014-05-05 18:07:42 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/248703002/1
6 years, 7 months ago (2014-05-05 18:08:40 UTC) #30
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 18:31:52 UTC) #31
Message was sent while issue was closed.
Change committed as 268226

Powered by Google App Engine
This is Rietveld 408576698