Use AnalysisDriverScheduler to schedule work across multiple AnalysisDriver(s).

Use AnalysisDriverScheduler to schedule work across multiple AnalysisDriver(s).

I don't like that it lives in the same file, but I'd not like to
expose internals of AnalysisDriver or AnalysisDriverScheduler outside :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b22ac9c93da3a56beefc6991091d66a4d326b90e

[Paul Berry, 2016-11-08 22:43:26]

lgtm

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:78: * The scheduler that
schedules analysis work in this, and possible other
s/possible/possibly/

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:828: // Find the driver with the
most priority work.
s/most/highest/

[Brian Wilkerson, 2016-11-08 22:47:45]

lgtm

> I don't like that it lives in the same file, but I'd not like to expose
> internals of AnalysisDriver or AnalysisDriverScheduler outside

I don't know why. The libraries are in 'src', and are in a package that has not
been published. I think you should split it up.

[scheglov, 2016-11-09 01:54:50]

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:78: * The scheduler that
schedules analysis work in this, and possible other
On 2016/11/08 22:43:26, Paul Berry wrote:
> s/possible/possibly/

Done.

https://codereview.chromium.org/2487003002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:828: // Find the driver with the
most priority work.
On 2016/11/08 22:43:26, Paul Berry wrote:
> s/most/highest/

Done.

[scheglov, 2016-11-09 02:05:21]

Description was changed from

==========
Use AnalysisDriverScheduler to schedule work across multiple AnalysisDriver(s).

I don't like that it lives in the same file, but I'd not like to
expose internals of AnalysisDriver or AnalysisDriverScheduler outside :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use AnalysisDriverScheduler to schedule work across multiple AnalysisDriver(s).

I don't like that it lives in the same file, but I'd not like to
expose internals of AnalysisDriver or AnalysisDriverScheduler outside :-(

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b22ac9c93da3a56beefc6991091d66a4d326b90e
==========

[scheglov, 2016-11-09 02:05:23]

Committed patchset #1 (id:1) manually as
b22ac9c93da3a56beefc6991091d66a4d326b90e (presubmit successful).