Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2486973003: [wasm] Data section without memory causes a validation error (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Data section without memory causes a validation error Another spec issue. R=titzer@chromium.org, rossberg@chromium.org TEST=unittests/WasmModuleVerifyTest.DataWithoutMemory Committed: https://crrev.com/bd472ffac3ae3e233d3f5dac7c5311e862a84834 Cr-Commit-Position: refs/heads/master@{#40855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/wasm/module-decoder.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 1 month ago (2016-11-09 09:24:06 UTC) #1
titzer
On 2016/11/09 09:24:06, ahaas wrote: lgtm
4 years, 1 month ago (2016-11-09 10:32:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486973003/1
4 years, 1 month ago (2016-11-09 10:35:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 10:37:12 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd472ffac3ae3e233d3f5dac7c5311e862a84834
Cr-Commit-Position: refs/heads/master@{#40855}

Powered by Google App Engine
This is Rietveld 408576698