views::Label: Enable text selection related tests on Mac.

ui/views/controls/label_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/compositor/canvas_painter.h"
 #include "ui/events/base_event_utils.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/render_text.h"
+#include "ui/gfx/switches.h"
 #include "ui/views/border.h"
 #include "ui/views/test/focus_manager_test.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
 
 using base::ASCIIToUTF16;
 
 #define EXPECT_STR_EQ(ascii, utf16) EXPECT_EQ(ASCIIToUTF16(ascii), utf16)
 
 namespace views {
@@ skipping 23 matching lines @@
   void TearDown() override {
     widget_.Close();
     ViewsTestBase::TearDown();
   }
 
  protected:
   Label* label() { return label_; }
 
   Widget* widget() { return &widget_; }
 
+ private:
+  Label* label_ = nullptr;
+  Widget widget_;
+
+  DISALLOW_COPY_AND_ASSIGN(LabelTest);
+};
+
+// Test fixture for text selection related tests.
+class LabelSelectionTest : public LabelTest {
+ public:
+  LabelSelectionTest() {}
+
+  // LabelTest overrides:
+  void SetUp() override {
+#if defined(OS_MACOSX)
+    // On Mac, by default RenderTextMac is used for labels which does not

[sky, 2016/11/09 16:23:10]

Is there a reason not to promoted this to LabelTest::SetUp and have it apply to
all?

[karandeepb, 2016/11/10 00:00:03]

For non text selection related tests, I wanted to have test coverage for
RenderTextMac as well, which is used currently. 

Alternatively, I can change LabelTest to use parameterized tests to test both
the underlying RenderText implementations for non text selection related tests.
However, since we don't actually use RTHB for Labels currently, this may not be
necessary.

+    // support text selection. Instead use RenderTextHarfBuzz for selection
+    // related tests. TODO(crbug.com/661394): Remove this once Mac also uses
+    // RenderTextHarfBuzz for Labels.
+    base::CommandLine::ForCurrentProcess()->AppendSwitch(
+        switches::kEnableHarfBuzzRenderText);
+#endif
+    LabelTest::SetUp();
+  }
+
+ protected:
   View* GetFocusedView() {
     return widget()->GetFocusManager()->GetFocusedView();
   }
 
   void PerformMousePress(const gfx::Point& point, int extra_flags = 0) {
     ui::MouseEvent pressed_event = ui::MouseEvent(
         ui::ET_MOUSE_PRESSED, point, point, ui::EventTimeForNow(),
         ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON | extra_flags);
     label()->OnMousePressed(pressed_event);
   }
@@ skipping 24 matching lines @@
         .origin();
   }
 
   base::string16 GetSelectedText() {
     const gfx::RenderText* render_text =
         label()->GetRenderTextForSelectionController();
     return render_text->GetTextFromRange(render_text->selection());
   }
 
  private:
-  Label* label_ = nullptr;
-  Widget widget_;
-
-  DISALLOW_COPY_AND_ASSIGN(LabelTest);
+  DISALLOW_COPY_AND_ASSIGN(LabelSelectionTest);
 };
 
 namespace {
 
 // All text sizing measurements (width and height) should be greater than this.
 const int kMinTextDimension = 4;
 
 class TestLabel : public Label {
  public:
   TestLabel() : Label(ASCIIToUTF16("TestLabel")) { SizeToPreferredSize(); }
@@ skipping 645 matching lines @@
 TEST_F(LabelTest, EmptyLabel) {
   label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   label()->RequestFocus();
   label()->SizeToPreferredSize();
 
   gfx::Rect focus_bounds = label()->GetFocusBounds();
   EXPECT_FALSE(focus_bounds.IsEmpty());
   EXPECT_LT(label()->font_list().GetHeight(), focus_bounds.height());
 }
 
-// Disabled on Mac since it uses RenderTextMac, which does not support text
-// selection.
-// TODO(crbug.com/661394): Re-enable these once Mac uses RenderTextHarfBuzz for
-// Labels.
-#if !defined(OS_MACOSX)
-TEST_F(LabelTest, Selectable) {
+TEST_F(LabelSelectionTest, Selectable) {
   // By default, labels don't support text selection.
   EXPECT_FALSE(label()->selectable());
 
   ASSERT_TRUE(label()->SetSelectable(true));
   EXPECT_TRUE(label()->selectable());
 
   // Verify that making a label multiline causes the label to not support text
   // selection.
   label()->SetMultiLine(true);
   EXPECT_FALSE(label()->selectable());
 }
 
 // Verify that labels supporting text selection get focus on clicks.
-TEST_F(LabelTest, FocusOnClick) {
+TEST_F(LabelSelectionTest, FocusOnClick) {
   label()->SetText(ASCIIToUTF16("text"));
   label()->SizeToPreferredSize();
 
   // By default, labels don't get focus on click.
   PerformClick(gfx::Point());
   EXPECT_NE(label(), GetFocusedView());
 
   ASSERT_TRUE(label()->SetSelectable(true));
   PerformClick(gfx::Point());
   EXPECT_EQ(label(), GetFocusedView());
 }
 
 // Verify that labels supporting text selection do not get focus on tab
 // traversal by default.
-TEST_F(LabelTest, FocusTraversal) {
+TEST_F(LabelSelectionTest, FocusTraversal) {
   // Add another view before |label()|.
   View* view = new View();
   view->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   widget()->GetContentsView()->AddChildViewAt(view, 0);
 
   // By default, labels are not focusable.
   view->RequestFocus();
   EXPECT_EQ(view, GetFocusedView());
   widget()->GetFocusManager()->AdvanceFocus(false);
   EXPECT_NE(label(), GetFocusedView());
 
   // On enabling text selection, labels can get focus on clicks but not via tab
   // traversal.
   view->RequestFocus();
   EXPECT_EQ(view, GetFocusedView());
   EXPECT_TRUE(label()->SetSelectable(true));
   widget()->GetFocusManager()->AdvanceFocus(false);
   EXPECT_NE(label(), GetFocusedView());
 
   // A label with FocusBehavior::ALWAYS should get focus via tab traversal.
   view->RequestFocus();
   EXPECT_EQ(view, GetFocusedView());
   EXPECT_TRUE(label()->SetSelectable(false));
   label()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
   widget()->GetFocusManager()->AdvanceFocus(false);
   EXPECT_EQ(label(), GetFocusedView());
 }
 
 // Verify label text selection behavior on double and triple clicks.
-TEST_F(LabelTest, DoubleTripleClick) {
+TEST_F(LabelSelectionTest, DoubleTripleClick) {
   label()->SetText(ASCIIToUTF16("Label double click"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformClick(gfx::Point());
   EXPECT_TRUE(GetSelectedText().empty());
 
   // Double clicking should select the word under cursor.
   PerformClick(gfx::Point(), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   // Triple clicking should select all the text.
   PerformClick(gfx::Point());
   EXPECT_EQ(label()->text(), GetSelectedText());
 
   // Clicking again should alternate to double click.
   PerformClick(gfx::Point());
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   // Clicking at another location should clear the selection.
   PerformClick(GetCursorPoint(8));
   EXPECT_TRUE(GetSelectedText().empty());
   PerformClick(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("double", GetSelectedText());
 }
 
 // Verify label text selection behavior on mouse drag.
-TEST_F(LabelTest, MouseDrag) {
+TEST_F(LabelSelectionTest, MouseDrag) {
   label()->SetText(ASCIIToUTF16("Label mouse drag"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformMousePress(GetCursorPoint(5));
   PerformMouseDragTo(gfx::Point());
   EXPECT_STR_EQ("Label", GetSelectedText());
 
   PerformMouseDragTo(GetCursorPoint(8));
   EXPECT_STR_EQ(" mo", GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(200, 0));
   PerformMouseRelease(gfx::Point(200, 0));
   EXPECT_STR_EQ(" mouse drag", GetSelectedText());
 }
 
 // Verify the initially selected word on a double click, remains selected on
 // mouse dragging.
-TEST_F(LabelTest, MouseDragWord) {
+TEST_F(LabelSelectionTest, MouseDragWord) {
   label()->SetText(ASCIIToUTF16("Label drag word"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   PerformClick(GetCursorPoint(8));
   PerformMousePress(GetCursorPoint(8), ui::EF_IS_DOUBLE_CLICK);
   EXPECT_STR_EQ("drag", GetSelectedText());
 
   PerformMouseDragTo(gfx::Point());
   EXPECT_STR_EQ("Label drag", GetSelectedText());
 
   PerformMouseDragTo(gfx::Point(200, 0));
   PerformMouseRelease(gfx::Point(200, 0));
   EXPECT_STR_EQ("drag word", GetSelectedText());
 }
-#endif  // OS_MACOSX
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 // Verify selection clipboard behavior on text selection. Disabled due to
 // http://crbug.com/396477.
-TEST_F(LabelTest, DISABLED_SelectionClipboard) {
+TEST_F(LabelSelectionTest, DISABLED_SelectionClipboard) {
   label()->SetText(ASCIIToUTF16("Label selection clipboard"));
   label()->SizeToPreferredSize();
   ASSERT_TRUE(label()->SetSelectable(true));
 
   // Verify programmatic modification of selection, does not modify the
   // selection clipboard.
   label()->SelectRange(gfx::Range(2, 5));
   EXPECT_STR_EQ("bel", GetSelectedText());
   EXPECT_TRUE(GetSelectionClipboardText().empty());
 
   // Verify text selection using the mouse updates the selection clipboard.
   PerformMousePress(GetCursorPoint(5));
   PerformMouseDragTo(gfx::Point());
   PerformMouseRelease(gfx::Point());
   EXPECT_STR_EQ("Label", GetSelectedText());
   EXPECT_STR_EQ("Label", GetSelectionClipboardText());
 }
 #endif
 
 }  // namespace views