DevTools: sort functions last in object previews

third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 WebInspector.RemoteObjectPreviewFormatter = class {
   /**
    * @param {!Element} parentElement
    * @param {!RuntimeAgent.ObjectPreview} preview
@@ skipping 28 matching lines @@
   /**
    * @param {!Element} parentElement
    * @param {!RuntimeAgent.ObjectPreview} preview
    */
   _appendPropertiesPreview(parentElement, preview) {
     var isArray = preview.subtype === 'array' || preview.subtype === 'typedarray';
     var arrayLength = WebInspector.RemoteObject.arrayLength(preview);
     var properties = preview.properties;
     if (isArray)
       properties = properties.slice().stableSort(compareIndexesFirst);
+    else
+      properties = properties.slice().stableSort(compareFunctionsLast);
 
     /**
      * @param {!RuntimeAgent.PropertyPreview} a
+     * @param {!RuntimeAgent.PropertyPreview} b
+     */
+    function compareFunctionsLast(a, b) {
+      if (a.type !== 'function' && b.type === 'function')
+        return -1;
+      else if (a.type === 'function' && b.type !== 'function')

[lushnikov, 2016/11/10 04:06:58]

style: no "else"

[luoe, 2016/11/10 17:33:53]

Done.

+        return 1;
+      return 0;
+    }
+
+    /**
+     * @param {!RuntimeAgent.PropertyPreview} a
      * @param {!RuntimeAgent.PropertyPreview} b
      */
     function compareIndexesFirst(a, b) {
       var index1 = toArrayIndex(a.name);
       var index2 = toArrayIndex(b.name);
       if (index1 < 0)
         return index2 < 0 ? 0 : 1;
       return index2 < 0 ? -1 : index1 - index2;
     }
 
@@ skipping 88 matching lines @@
 
     if (type === 'object' && !subtype) {
       span.textContent = this._abbreviateFullQualifiedClassName(description);
       return span;
     }
 
     span.textContent = description;
     return span;
   }
 };