Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2486953002:
DevTools: sort functions last in object previews (Closed)
|
Created:
4 years, 1 month ago by luoe Modified:
4 years, 1 month ago Reviewers:
lushnikov CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: sort functions last in object previews
In the near future, injected script source will add functions to object
previews. This CL is made in preparation for that change.
BUG=645053
Committed: https://crrev.com/4713c97d015f1010216edb6b785e0707b0c72dc7
Cr-Commit-Position: refs/heads/master@{#431348}
Patch Set 1 #
Total comments: 2
Patch Set 2 : ac #Messages
Total messages: 24 (18 generated)
Description was changed from ========== DevTools: sort functions last in object previews BUG=645053 ========== to ========== DevTools: sort functions last in object previews In the near future, injected script source will add functions to object previews. This CL is made in preparation for that change. BUG=645053 ==========
luoe@chromium.org changed reviewers: + lushnikov@chromium.org
lgtm https://codereview.chromium.org/2486953002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js (right): https://codereview.chromium.org/2486953002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:59: else if (a.type === 'function' && b.type !== 'function') style: no "else"
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2486953002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js (right): https://codereview.chromium.org/2486953002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js:59: else if (a.type === 'function' && b.type !== 'function') On 2016/11/10 04:06:58, lushnikov wrote: > style: no "else" Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by luoe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2486953002/#ps20001 (title: "ac")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: sort functions last in object previews In the near future, injected script source will add functions to object previews. This CL is made in preparation for that change. BUG=645053 ========== to ========== DevTools: sort functions last in object previews In the near future, injected script source will add functions to object previews. This CL is made in preparation for that change. BUG=645053 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: sort functions last in object previews In the near future, injected script source will add functions to object previews. This CL is made in preparation for that change. BUG=645053 ========== to ========== DevTools: sort functions last in object previews In the near future, injected script source will add functions to object previews. This CL is made in preparation for that change. BUG=645053 Committed: https://crrev.com/4713c97d015f1010216edb6b785e0707b0c72dc7 Cr-Commit-Position: refs/heads/master@{#431348} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4713c97d015f1010216edb6b785e0707b0c72dc7 Cr-Commit-Position: refs/heads/master@{#431348} |
