Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2486943006: Update test expectations for a test which passes slightly more (Closed)

Created:
4 years, 1 month ago by Dan Ehrenberg
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update test expectations for a test which passes slightly more Freezing the prototype chain of the global object made a line of a test pass which was checking that, cross-origin, this chain cannot be manipulated. This patch updates the test expectations for the test doing better. BUG=664256, v8:5149 Committed: https://crrev.com/6e4c3b357983e3d687d135297ed9f0f7c44031f5 Cr-Commit-Position: refs/heads/master@{#431496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Dan Ehrenberg
4 years, 1 month ago (2016-11-10 22:55:16 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-10 22:57:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486943006/1
4 years, 1 month ago (2016-11-10 23:01:09 UTC) #6
qyearsley
lgtm
4 years, 1 month ago (2016-11-10 23:06:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/329762)
4 years, 1 month ago (2016-11-11 03:27:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486943006/1
4 years, 1 month ago (2016-11-11 03:32:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486943006/1
4 years, 1 month ago (2016-11-11 03:42:11 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 04:27:14 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e4c3b357983e3d687d135297ed9f0f7c44031f5 Cr-Commit-Position: refs/heads/master@{#431496}
4 years, 1 month ago (2016-11-11 05:16:19 UTC) #17
Yuki
4 years, 1 month ago (2016-11-11 07:36:50 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698