Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2486943005: [wasm] Imported WebAssembly function are never wrapped. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Imported WebAssembly function are never wrapped. According to the spec, import wrappers are only generated for JavaScript functions, not for WebAssembly function. If an imported WebAssembly function does not have the expected type, then a type error is thrown. R=titzer@chromium.org, rossberg@chromium.org TEST=mjsunit/wasm/test-import-export-wrapper Committed: https://crrev.com/665a5d17acc17c85d61a99363d61514656d4b6ea Cr-Commit-Position: refs/heads/master@{#40901}

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M src/wasm/wasm-module.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/test-import-export-wrapper.js View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ahaas
4 years, 1 month ago (2016-11-10 14:14:48 UTC) #1
titzer
On 2016/11/10 14:14:48, ahaas wrote: lgtm with grammar nazi nits
4 years, 1 month ago (2016-11-10 14:26:23 UTC) #4
ahaas
On 2016/11/10 at 14:26:23, titzer wrote: > On 2016/11/10 14:14:48, ahaas wrote: > > lgtm ...
4 years, 1 month ago (2016-11-10 14:27:37 UTC) #5
titzer
https://codereview.chromium.org/2486943005/diff/1/test/mjsunit/wasm/test-import-export-wrapper.js File test/mjsunit/wasm/test-import-export-wrapper.js (right): https://codereview.chromium.org/2486943005/diff/1/test/mjsunit/wasm/test-import-export-wrapper.js#newcode131 test/mjsunit/wasm/test-import-export-wrapper.js:131: // In this case, second_export has less params than ...
4 years, 1 month ago (2016-11-10 14:28:41 UTC) #6
ahaas
https://codereview.chromium.org/2486943005/diff/1/test/mjsunit/wasm/test-import-export-wrapper.js File test/mjsunit/wasm/test-import-export-wrapper.js (right): https://codereview.chromium.org/2486943005/diff/1/test/mjsunit/wasm/test-import-export-wrapper.js#newcode131 test/mjsunit/wasm/test-import-export-wrapper.js:131: // In this case, second_export has less params than ...
4 years, 1 month ago (2016-11-10 14:38:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486943005/20001
4 years, 1 month ago (2016-11-10 14:38:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 15:05:15 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/665a5d17acc17c85d61a99363d61514656d4b6ea
Cr-Commit-Position: refs/heads/master@{#40901}

Powered by Google App Engine
This is Rietveld 408576698