Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2486923007: Create pkg/front_end/src/base and begin populating with general use classes. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create pkg/front_end/src/base and begin populating with general use classes. In the long run, pkg/front_end/src/base is intended to contain code that is useful to many components of the front end. In this initial implementation, it contains: - Source and the classes it references - ErrorCode, ErrorSeverity, and ErrorType - SyntacticEntity Note that AnalysisTarget is included (even though strictly speaking it is part of the analyzer task model) because it was too hard to disentangle from Source. Note that Token classes remain in pkg/front_end/src/scanner for now; I plan to reorganize them at the time the parser is moved into the front end. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4cd9b28eb64c1eed5c24f490dee906a860eaa142

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -631 lines) Patch
M pkg/analyzer/lib/dart/ast/syntactic_entity.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +2 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 3 chunks +5 lines, -227 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +3 lines, -21 lines 0 comments Download
A pkg/front_end/lib/src/base/analysis_target.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A + pkg/front_end/lib/src/base/errors.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
A pkg/front_end/lib/src/base/source.dart View 1 chunk +148 lines, -0 lines 0 comments Download
A + pkg/front_end/lib/src/base/syntactic_entity.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/front_end/lib/src/base/timestamped_data.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/base/uri_kind.dart View 1 chunk +87 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/scanner/errors.dart View 1 chunk +1 line, -278 lines 0 comments Download
D pkg/front_end/lib/src/scanner/syntactic_entity.dart View 1 chunk +0 lines, -26 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-12 01:25:20 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-14 15:46:30 UTC) #3
Paul Berry
4 years, 1 month ago (2016-11-14 17:20:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4cd9b28eb64c1eed5c24f490dee906a860eaa142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698