Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2486923005: Timeline: add moar attributes in frame instrumentation (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 WebInspector.TimelineTreeView = class extends WebInspector.VBox { 7 WebInspector.TimelineTreeView = class extends WebInspector.VBox {
8 constructor() { 8 constructor() {
9 super(); 9 super();
10 this.element.classList.add('timeline-tree-view'); 10 this.element.classList.add('timeline-tree-view');
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 } 149 }
150 150
151 /** 151 /**
152 * @return {!WebInspector.TimelineProfileTree.Node} 152 * @return {!WebInspector.TimelineProfileTree.Node}
153 */ 153 */
154 _buildTree() { 154 _buildTree() {
155 throw new Error('Not Implemented'); 155 throw new Error('Not Implemented');
156 } 156 }
157 157
158 /** 158 /**
159 * @param {function(!WebInspector.TracingModel.Event, string):(string|symbol)= } eventIdCallback 159 * @param {function(!WebInspector.TracingModel.Event):(string|symbol)=} eventI dCallback
160 * @return {!WebInspector.TimelineProfileTree.Node} 160 * @return {!WebInspector.TimelineProfileTree.Node}
161 */ 161 */
162 _buildTopDownTree(eventIdCallback) { 162 _buildTopDownTree(eventIdCallback) {
163 return WebInspector.TimelineProfileTree.buildTopDown( 163 return WebInspector.TimelineProfileTree.buildTopDown(
164 this._model.mainThreadEvents(), this._filters, this._startTime, this._en dTime, eventIdCallback); 164 this._model.mainThreadEvents(), this._filters, this._startTime, this._en dTime, eventIdCallback);
165 } 165 }
166 166
167 /** 167 /**
168 * @param {!Array<!WebInspector.DataGrid.ColumnDescriptor>} columns 168 * @param {!Array<!WebInspector.DataGrid.ColumnDescriptor>} columns
169 */ 169 */
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 */ 604 */
605 _showDetailsForNode(node) { 605 _showDetailsForNode(node) {
606 var stack = this._buildHeaviestStack(node); 606 var stack = this._buildHeaviestStack(node);
607 this._stackView.setStack(stack, node); 607 this._stackView.setStack(stack, node);
608 this._stackView.show(this._detailsView.element); 608 this._stackView.show(this._detailsView.element);
609 return true; 609 return true;
610 } 610 }
611 611
612 /** 612 /**
613 * @param {!WebInspector.AggregatedTimelineTreeView.GroupBy} groupBy 613 * @param {!WebInspector.AggregatedTimelineTreeView.GroupBy} groupBy
614 * @return {function(!WebInspector.TracingModel.Event, string):string} 614 * @return {function(!WebInspector.TracingModel.Event):string}
615 */ 615 */
616 _groupingFunction(groupBy) { 616 _groupingFunction(groupBy) {
617 /** 617 /**
618 * @param {!WebInspector.TracingModel.Event} event 618 * @param {!WebInspector.TracingModel.Event} event
619 * @return {string} 619 * @return {string}
620 */ 620 */
621 function groupByURL(event) { 621 function groupByURL(event) {
622 return WebInspector.TimelineProfileTree.eventURL(event) || ''; 622 return WebInspector.TimelineProfileTree.eventURL(event) || '';
623 } 623 }
624 624
(...skipping 26 matching lines...) Expand all
651 return event => WebInspector.TimelineUIUtils.eventStyle(event).title; 651 return event => WebInspector.TimelineUIUtils.eventStyle(event).title;
652 case WebInspector.AggregatedTimelineTreeView.GroupBy.Category: 652 case WebInspector.AggregatedTimelineTreeView.GroupBy.Category:
653 return event => WebInspector.TimelineUIUtils.eventStyle(event).category. name; 653 return event => WebInspector.TimelineUIUtils.eventStyle(event).category. name;
654 case WebInspector.AggregatedTimelineTreeView.GroupBy.Subdomain: 654 case WebInspector.AggregatedTimelineTreeView.GroupBy.Subdomain:
655 return groupByDomain.bind(null, false); 655 return groupByDomain.bind(null, false);
656 case WebInspector.AggregatedTimelineTreeView.GroupBy.Domain: 656 case WebInspector.AggregatedTimelineTreeView.GroupBy.Domain:
657 return groupByDomain.bind(null, true); 657 return groupByDomain.bind(null, true);
658 case WebInspector.AggregatedTimelineTreeView.GroupBy.URL: 658 case WebInspector.AggregatedTimelineTreeView.GroupBy.URL:
659 return groupByURL; 659 return groupByURL;
660 case WebInspector.AggregatedTimelineTreeView.GroupBy.Frame: 660 case WebInspector.AggregatedTimelineTreeView.GroupBy.Frame:
661 return (event, pageFrameId) => pageFrameId || ''; 661 return event => WebInspector.TimelineData.forEvent(event).frameId;
662 default: 662 default:
663 console.assert(false, `Unexpected aggregation setting: ${groupBy}`); 663 console.assert(false, `Unexpected aggregation setting: ${groupBy}`);
664 return () => Symbol('uniqueGroupId'); 664 return () => Symbol('uniqueGroupId');
665 } 665 }
666 } 666 }
667 667
668 /** 668 /**
669 * @param {string} url 669 * @param {string} url
670 * @return {boolean} 670 * @return {boolean}
671 */ 671 */
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 924
925 _onSelectionChanged() { 925 _onSelectionChanged() {
926 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Selectio nChanged); 926 this.dispatchEventToListeners(WebInspector.TimelineStackView.Events.Selectio nChanged);
927 } 927 }
928 }; 928 };
929 929
930 /** @enum {symbol} */ 930 /** @enum {symbol} */
931 WebInspector.TimelineStackView.Events = { 931 WebInspector.TimelineStackView.Events = {
932 SelectionChanged: Symbol('SelectionChanged') 932 SelectionChanged: Symbol('SelectionChanged')
933 }; 933 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698