Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2486923004: [crankshaft] Fix constant folding of HDiv instruction. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix constant folding of HDiv instruction. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-662367 BUG=chromium:662367 Committed: https://crrev.com/25d2268ecc14b07671e94b7835a3519cdc29e8b0 Cr-Commit-Position: refs/heads/master@{#40897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-662367.js View 1 chunk +28 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-10 13:52:16 UTC) #3
Jarin
lgtm. Thanks!
4 years, 1 month ago (2016-11-10 14:10:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486923004/1
4 years, 1 month ago (2016-11-10 14:25:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 14:27:29 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d2268ecc14b07671e94b7835a3519cdc29e8b0
Cr-Commit-Position: refs/heads/master@{#40897}

Powered by Google App Engine
This is Rietveld 408576698