scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json - Issue 2486923002: Use devil's adb with each bisect iteration, also start/stop daemons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json

Issue 2486923002: Use devil's adb with each bisect iteration, also start/stop daemons. (Closed)

Patch Set: Rebase and address comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_nexus6_perf_bisect.json ('K') | « scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json ('k') | scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json

diff --git a/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json b/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json

index d1c994aee47ae2ffeecbc1e33fe1d2946651681c..64332037a449770b5139cf7f14c0af156cd4330f 100644

--- a/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json

+++ b/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_cq_run_benchmark_android_s5_perf_cq.json

@@ -215,7 +215,7 @@

"cmd": [

"python",

"-u",

- "\nimport sys\nsys.path.append(sys.argv[1])\nfrom devil import devil_env\ndevil_env.config.Initialize()\ndevil_env.config.PrefetchPaths(dependencies=['adb'])\n",

+ "\nimport sys\nsys.path.append(sys.argv[1])\nfrom devil import devil_env\nfrom devil.android.sdk import adb_wrapper\ndevil_env.config.Initialize()\ndevil_env.config.PrefetchPaths(dependencies=['adb'])\nadb_wrapper.AdbWrapper.StartServer()\n",

"[BUILDER_CACHE]/android_s5_perf_cq/src/third_party/catapult/devil"

"name": "initialize devil",

@@ -224,8 +224,10 @@

"@@@STEP_LOG_LINE@python.inline@import sys@@@",

"@@@STEP_LOG_LINE@python.inline@sys.path.append(sys.argv[1])@@@",

"@@@STEP_LOG_LINE@python.inline@from devil import devil_env@@@",

+ "@@@STEP_LOG_LINE@python.inline@from devil.android.sdk import adb_wrapper@@@",

"@@@STEP_LOG_LINE@python.inline@devil_env.config.Initialize()@@@",

"@@@STEP_LOG_LINE@python.inline@devil_env.config.PrefetchPaths(dependencies=['adb'])@@@",

+ "@@@STEP_LOG_LINE@python.inline@adb_wrapper.AdbWrapper.StartServer()@@@",

"@@@STEP_LOG_END@python.inline@@@"

]