Use devil's adb with each bisect iteration, also start/stop daemons.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 import datetime
 import json
 import os
 import pipes
 import re
@@ skipping 300 matching lines @@
   def use_devil_adb(self):
     # TODO(jbudorick): Remove this after resolving
     # https://github.com/catapult-project/catapult/issues/2901
     devil_path = self.m.path['checkout'].join('third_party', 'catapult', 'devil')
     self.m.python.inline(
         'initialize devil',
         """
         import sys
         sys.path.append(sys.argv[1])
         from devil import devil_env
+        from devil.android.sdk import adb_wrapper
         devil_env.config.Initialize()
         devil_env.config.PrefetchPaths(dependencies=['adb'])
+        adb_wrapper.AdbWrapper.StartServer()
         """,
         args=[devil_path])
     self.m.adb.set_adb_path(
         devil_path.join('bin', 'deps', 'linux2', 'x86_64', 'bin', 'adb'))
 
   def create_adb_symlink(self):
     # Creates a sym link to the adb executable in the home dir
     self.m.python(
         'create adb symlink',
         self.m.path['checkout'].join('build', 'symlink.py'),
@@ skipping 821 matching lines @@
       self.asan_device_setup()
 
   def common_tests_final_steps(self, logcat_gs_bucket='chromium-android'):
     self.shutdown_device_monitor()
     self.logcat_dump(gs_bucket=logcat_gs_bucket)
     self.stack_tool_steps()
     if self.m.chromium.c.gyp_env.GYP_DEFINES.get('asan', 0) == 1:
       self.asan_device_teardown()
     self.test_report()
 
+  def android_build_wrapper(self, logcat_gs_bucket='chromium-android'):
+    @contextlib.contextmanager
+    def wrapper(bisect_obj):

[jbudorick, 2016/11/09 23:51:46]

nit: This shouldn't be "bisect_obj" if it's here.

[jbudorick, 2016/11/10 01:17:37]

(and once ensure_checkout moves into bisect, this should be `api` w/ bisect
passing in bisect_obj.m)

[ghost stip (do not use), 2016/11/11 01:08:17]

Done.

+      """A context manager for use as auto_bisect's build_context_mgr.
+
+      This wraps every overall bisect run.
+      """
+      try:
+        bisect_obj.m.chromium_android.common_tests_setup_steps(

[jbudorick, 2016/11/09 23:51:45]

When doing something like

  with android_build_wrapper()():
    with android_test_wrapper():

we will spawn the monitors twice. That seems wrong.

+            perf_setup=True, remove_system_webview=True)
+        bisect_obj.m.chromium.runhooks()
+
+        yield
+      finally:
+        bisect_obj.ensure_checkout()

[jbudorick, 2016/11/09 23:51:45]

...?

[ghost stip (do not use), 2016/11/10 00:51:57]

so we're in chromium_android. ensure_checkout is part of auto_bisect, and
auto_bisect_staging. I could hardcode the ensure_checkout, but then that defeats
the split between _staging and prod. I can pull it out and make it part of the
bisect wrapper, but then we're reordering things.

[jbudorick, 2016/11/10 01:00:29]

Not following you here.
This definitely should be in bisect, not in chromium_android. Not sure about
reordering, though.

[ghost stip (do not use), 2016/11/10 01:05:33]

if we're okay with ensure_checkout coming after common_tests_final_steps, then
this all becomes much simpler

+        bisect_obj.m.chromium_android.common_tests_final_steps(
+          logcat_gs_bucket=logcat_gs_bucket)
+    return wrapper
+
+  def android_test_wrapper(self, logcat_gs_bucket='chromium-android'):
+    @contextlib.contextmanager
+    def wrapper(_bisect_obj):

[jbudorick, 2016/11/09 23:51:45]

nit: same

+      """A context manager for running android test steps."""
+      try:
+        self.spawn_logcat_monitor()
+        self.spawn_device_monitor()
+
+        yield
+      finally:
+        self.shutdown_device_monitor()
+        self.logcat_dump(gs_bucket=logcat_gs_bucket)
+        self.stack_tool_steps()
+    return wrapper
+
   def run_bisect_script(self, extra_src='', path_to_config='', **kwargs):
     self.m.step('prepare bisect perf regression',
         [self.m.path['checkout'].join('tools',
                                       'prepare-bisect-perf-regression.py'),
          '-w', self.m.path['slave_build']])
 
     args = []
     if extra_src:
       args = args + ['--extra_src', extra_src]
     if path_to_config:
@@ skipping 440 matching lines @@
       script = self.c.test_runner
       if wrapper_script_suite_name:
         script = self.m.chromium.output_dir.join('bin', 'run_%s' %
                                                  wrapper_script_suite_name)
       else:
         env = kwargs.get('env', {})
         env['CHROMIUM_OUTPUT_DIR'] = env.get('CHROMIUM_OUTPUT_DIR',
                                              self.m.chromium.output_dir)
         kwargs['env'] = env
       return self.m.python(step_name, script, args, **kwargs)