testing/scripts/run_devtools_check.py - Issue 2486903002: DevTools: Add support for installing node and running eslint over devtools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/scripts/run_devtools_check.py

Issue 2486903002: DevTools: Add support for installing node and running eslint over devtools. (Closed)

Patch Set: fix node.py Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/scripts/run_devtools_check.py

diff --git a/testing/scripts/run_devtools_closure_compile.py b/testing/scripts/run_devtools_check.py

similarity index 92%

rename from testing/scripts/run_devtools_closure_compile.py

rename to testing/scripts/run_devtools_check.py

index 1c6d088745058a7f7f673ae0377438fdc209d97e..60d0116ed4ccbfef91398a5cc1d897f0cf231256 100755

--- a/testing/scripts/run_devtools_closure_compile.py

+++ b/testing/scripts/run_devtools_check.py

@@ -50,8 +50,11 @@ def main():

'failures': ['failed'] if ret else []}, fp)

return ret

+# This is not really a "script test" so does not need to manually add

+# any additional compile targets.

def main_compile_targets(args):

- json.dump(['devtools_closure_compile'], args.output)

+ json.dump([''], args.output)

if __name__ == '__main__':

« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | testing/scripts/run_devtools_closure_compile.py » ('j') | no next file with comments »