DevTools: Add support for installing node and running eslint over devtools.

testing/scripts/run_devtools_eslint.py

Index: testing/scripts/run_devtools_eslint.py
diff --git a/testing/scripts/run_devtools_eslint.py b/testing/scripts/run_devtools_eslint.py
new file mode 100755
index 0000000000000000000000000000000000000000..4bb7eef5b6f781398e87045b9276f13bdb429676
--- /dev/null
+++ b/testing/scripts/run_devtools_eslint.py
@@ -0,0 +1,65 @@
+#!/usr/bin/env python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Runs a python script under an isolate
+
+This script attempts to emulate the contract of gtest-style tests
+invoked via recipes. The main contract is that the caller passes the
+argument:
+
+  --isolated-script-test-output=[FILENAME]
+
+json is written to that file in the format produced by
+common.parse_common_test_results.
+
+This script is intended to be the base command invoked by the isolate,
+followed by a subsequent Python script."""
+
+import argparse
+import json
+import os
+import sys
+
+
+import common
+
+# Add src/testing/ into sys.path for importing xvfb.
+sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
+import xvfb
+
+
+def main():
+  parser = argparse.ArgumentParser()
+  parser.add_argument('--isolated-script-test-output', type=str,
+                      required=True)
+  args, rest_args = parser.parse_known_args()
+  # Remove the chartjson extra arg until this script cares about chartjson
+  # results
+  index = 0
+  for arg in rest_args:
+    if '--isolated-script-test-chartjson-output' in arg:
+      rest_args.pop(index)
+      break
+    index += 1
+
+  ret = common.run_command([sys.executable] + rest_args)
+  with open(args.isolated_script_test_output, 'w') as fp:
+    json.dump({'valid': True,
+               'failures': ['failed'] if ret else []}, fp)
+  return ret
+
+def main_compile_targets(args):
+  json.dump(['devtools_eslint'], args.output)

[Dirk Pranke, 2016/12/07 03:10:41]

Is line 54 the only difference between this file and
run_devtools_closure_compile.py ?

If so, I'm wondering if we can just use a single script for both? I *think* that
if you set the override_compile_targets in the *.json files, it should probably
work.

[Ken Russell (switch to Gerrit), 2016/12/07 06:50:25]

I'm 99.99% sure (unless someone rewrote the recipe-side code; I'm looking
through it now but can't verify 100%) that this is not actually used by the
recipes during the build step. Yes, it should be possible to reuse the same
script. There should be two GN targets, both of which should include the same
script as a data dependency, with their own unique dependencies as well. Note
that the isolated script run_gpu_integration_test_as_googletest.py is used to
run many different steps on the bots. I suggest using it as an example.

In addition to changing this code to dump [''], I would add a comment indicating
that recipes do not call this entry point for isolated scripts.

[chenwilliam, 2016/12/08 02:52:26]

Done. Consolidated my two run_devtools_* script into one.

+
+
+if __name__ == '__main__':
+  # Conform minimally to the protocol defined by ScriptTest.
+  if 'compile_targets' in sys.argv:
+    funcs = {
+      'run': None,
+      'compile_targets': main_compile_targets,
+    }
+    sys.exit(common.run_script(sys.argv[1:], funcs))
+  sys.exit(main())