cryptohome: Move stateless wrapper functions out of CryptohomeLibrary

chrome/browser/policy/browser_policy_connector.cc

Index: chrome/browser/policy/browser_policy_connector.cc
diff --git a/chrome/browser/policy/browser_policy_connector.cc b/chrome/browser/policy/browser_policy_connector.cc
index 28c2036d1ded7bd2a7961ad8a1112e7dad325222..24f043b33b7723d311ecec1bf65c57d20cea0962 100644
--- a/chrome/browser/policy/browser_policy_connector.cc
+++ b/chrome/browser/policy/browser_policy_connector.cc
@@ -134,12 +134,10 @@ BrowserPolicyConnector::BrowserPolicyConnector()
   // CryptohomeLibrary or DBusThreadManager may be uninitialized on unit tests.
   if (chromeos::CryptohomeLibrary::IsInitialized() &&

[pneubeck (no reviews), 2013/09/27 08:59:25]

this shouldn't be required anymore (update the comment too please)

[satorux1, 2013/10/01 05:24:03]

This turned out to be necessary, as removing it will cause tests to fail (the
code inside the if-block will be run if CryptohomeLibrary::IsInitialized() is
removed). For now, let me add a TODO here.

[pneubeck (no reviews), 2013/10/01 09:05:08]

...how we love implicit dependencies...

       chromeos::DBusThreadManager::IsInitialized()) {
-    chromeos::CryptohomeLibrary* cryptohome =
-        chromeos::CryptohomeLibrary::Get();
     chromeos::CryptohomeClient* cryptohome_client =
         chromeos::DBusThreadManager::Get()->GetCryptohomeClient();
     install_attributes_.reset(
-        new EnterpriseInstallAttributes(cryptohome, cryptohome_client));
+        new EnterpriseInstallAttributes(cryptohome_client));
     base::FilePath install_attrs_file;
     CHECK(PathService::Get(chromeos::FILE_INSTALL_ATTRIBUTES,
                            &install_attrs_file));