Fix static field initialization in optimzed DBC code.

Fix static field initialization in optimzed DBC code.

Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

Fixes #27787.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/a77d860806967aef877aec28b19516516ebce297

[Florian Schneider, 2016-11-08 19:00:54]

Description was changed from

==========
Fix static field initialization in optimzed DBC code.

Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

BUG=
==========

to

==========
Fix static field initialization in optimzed DBC code.

Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

Fixes #27787.
==========

[Florian Schneider, 2016-11-08 19:01:05]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2016-11-08 19:03:25]

lgtm

[Florian Schneider, 2016-11-08 19:21:52]

Description was changed from

==========
Fix static field initialization in optimzed DBC code.

Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

Fixes #27787.
==========

to

==========
Fix static field initialization in optimzed DBC code.

Static fields can be initialized from optimized code. This CL
adds support for handling InitStaticFieldInstr in optimized code.

Fixes #27787.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a77d860806967aef877aec28b19516516ebce297
==========

[Florian Schneider, 2016-11-08 19:21:53]

Committed patchset #1 (id:1) manually as
a77d860806967aef877aec28b19516516ebce297 (presubmit successful).

[Vyacheslav Egorov (Google), 2016-11-09 09:28:28]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-11-09 09:28:29]

DBC

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:424: __ InitStaticTOS();
This looks like a call. Does this need compiler->RecordAfterCall(this)?

[Florian Schneider, 2016-11-09 13:51:52]

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:424: __ InitStaticTOS();
On 2016/11/09 09:28:28, Vyacheslav Egorov (Google) wrote:
> This looks like a call. Does this need compiler->RecordAfterCall(this)?

Actually yes, good point. It could throw, or cause a lazy deopt. 

Will deopt still work with the input pushed on the stack, or do I have to add a
InitStaticFieldOpt bytecode that takes a register as input?

[Vyacheslav Egorov (Google), 2016-11-09 13:55:11]

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:424: __ InitStaticTOS();
On 2016/11/09 13:51:52, Florian Schneider wrote:
> On 2016/11/09 09:28:28, Vyacheslav Egorov (Google) wrote:
> > This looks like a call. Does this need compiler->RecordAfterCall(this)?
> 
> Actually yes, good point. It could throw, or cause a lazy deopt. 
> 
> Will deopt still work with the input pushed on the stack, or do I have to add
a
> InitStaticFieldOpt bytecode that takes a register as input?

I think it should work. 

Maybe write a test?

[Florian Schneider, 2016-11-09 14:22:04]

On 2016/11/09 13:55:11, Vyacheslav Egorov (Google) wrote:
>
https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
> File runtime/vm/intermediate_language_dbc.cc (right):
> 
>
https://codereview.chromium.org/2486863002/diff/1/runtime/vm/intermediate_lan...
> runtime/vm/intermediate_language_dbc.cc:424: __ InitStaticTOS();
> On 2016/11/09 13:51:52, Florian Schneider wrote:
> > On 2016/11/09 09:28:28, Vyacheslav Egorov (Google) wrote:
> > > This looks like a call. Does this need compiler->RecordAfterCall(this)?
> > 
> > Actually yes, good point. It could throw, or cause a lazy deopt. 
> > 
> > Will deopt still work with the input pushed on the stack, or do I have to
add
> a
> > InitStaticFieldOpt bytecode that takes a register as input?
> 
> I think it should work. 
> 
> Maybe write a test?

I'll add a test. I see this in other places as well (e.g. optimized static call
where we push the function), so I think it should work as well.