Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 2486853002: Timeline: remove TimelineModel inferred properties from TracingModel.Event (Closed)
Patch Set: addressed comments and rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 var markersPath = new Path2D(); 372 var markersPath = new Path2D();
373 for (var i = 0; i < frames.length; ++i) { 373 for (var i = 0; i < frames.length; ++i) {
374 var frame = frames[i]; 374 var frame = frames[i];
375 if (!frame.hasWarnings()) 375 if (!frame.hasWarnings())
376 continue; 376 continue;
377 paintWarningDecoration(frame.startTime, frame.duration); 377 paintWarningDecoration(frame.startTime, frame.duration);
378 } 378 }
379 379
380 var events = this._model.mainThreadEvents(); 380 var events = this._model.mainThreadEvents();
381 for (var i = 0; i < events.length; ++i) { 381 for (var i = 0; i < events.length; ++i) {
382 if (!events[i].warning) 382 if (!WebInspector.TimelineData.forEvent(events[i]).warning)
383 continue; 383 continue;
384 paintWarningDecoration(events[i].startTime, events[i].duration); 384 paintWarningDecoration(events[i].startTime, events[i].duration);
385 } 385 }
386 386
387 ctx.fillStyle = 'hsl(0, 80%, 90%)'; 387 ctx.fillStyle = 'hsl(0, 80%, 90%)';
388 ctx.strokeStyle = 'red'; 388 ctx.strokeStyle = 'red';
389 ctx.lineWidth = 2 * window.devicePixelRatio; 389 ctx.lineWidth = 2 * window.devicePixelRatio;
390 ctx.fill(fillPath); 390 ctx.fill(fillPath);
391 ctx.stroke(markersPath); 391 ctx.stroke(markersPath);
392 392
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 counters[group] = this._quantDuration; 776 counters[group] = this._quantDuration;
777 this._callback(counters); 777 this._callback(counters);
778 interval -= this._quantDuration; 778 interval -= this._quantDuration;
779 } 779 }
780 this._counters = []; 780 this._counters = [];
781 this._counters[group] = interval; 781 this._counters[group] = interval;
782 this._lastTime = time; 782 this._lastTime = time;
783 this._remainder = this._quantDuration - interval; 783 this._remainder = this._quantDuration - interval;
784 } 784 }
785 }; 785 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698