Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2486843003: Allow navigations to non-web-accessible resources from chrome schemes. (Closed)
Patch Set: nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/chrome_content_browser_client_extensions_par t.h" 5 #include "chrome/browser/extensions/chrome_content_browser_client_extensions_par t.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 10
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/debug/alias.h" 12 #include "base/debug/alias.h"
13 #include "base/debug/dump_without_crashing.h" 13 #include "base/debug/dump_without_crashing.h"
14 #include "base/metrics/histogram_macros.h" 14 #include "base/metrics/histogram_macros.h"
15 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/extensions/extension_service.h" 16 #include "chrome/browser/extensions/extension_service.h"
17 #include "chrome/browser/extensions/extension_web_ui.h" 17 #include "chrome/browser/extensions/extension_web_ui.h"
18 #include "chrome/browser/extensions/extension_webkit_preferences.h" 18 #include "chrome/browser/extensions/extension_webkit_preferences.h"
19 #include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h" 19 #include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
20 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/browser/profiles/profile_io_data.h" 21 #include "chrome/browser/profiles/profile_io_data.h"
22 #include "chrome/browser/profiles/profile_manager.h" 22 #include "chrome/browser/profiles/profile_manager.h"
23 #include "chrome/browser/renderer_host/chrome_extension_message_filter.h" 23 #include "chrome/browser/renderer_host/chrome_extension_message_filter.h"
24 #include "chrome/browser/sync_file_system/local/sync_file_system_backend.h" 24 #include "chrome/browser/sync_file_system/local/sync_file_system_backend.h"
25 #include "chrome/common/chrome_constants.h" 25 #include "chrome/common/chrome_constants.h"
26 #include "chrome/common/chrome_switches.h" 26 #include "chrome/common/chrome_switches.h"
27 #include "chrome/common/extensions/extension_process_policy.h" 27 #include "chrome/common/extensions/extension_process_policy.h"
28 #include "chrome/common/url_constants.h"
28 #include "components/guest_view/browser/guest_view_message_filter.h" 29 #include "components/guest_view/browser/guest_view_message_filter.h"
29 #include "content/public/browser/browser_thread.h" 30 #include "content/public/browser/browser_thread.h"
30 #include "content/public/browser/browser_url_handler.h" 31 #include "content/public/browser/browser_url_handler.h"
31 #include "content/public/browser/render_process_host.h" 32 #include "content/public/browser/render_process_host.h"
32 #include "content/public/browser/render_view_host.h" 33 #include "content/public/browser/render_view_host.h"
33 #include "content/public/browser/resource_dispatcher_host.h" 34 #include "content/public/browser/resource_dispatcher_host.h"
34 #include "content/public/browser/site_instance.h" 35 #include "content/public/browser/site_instance.h"
35 #include "content/public/browser/storage_partition.h" 36 #include "content/public/browser/storage_partition.h"
36 #include "content/public/browser/vpn_service_proxy.h" 37 #include "content/public/browser/vpn_service_proxy.h"
37 #include "content/public/browser/web_contents.h" 38 #include "content/public/browser/web_contents.h"
38 #include "content/public/common/content_switches.h" 39 #include "content/public/common/content_switches.h"
40 #include "content/public/common/url_constants.h"
39 #include "extensions/browser/api/web_request/web_request_api.h" 41 #include "extensions/browser/api/web_request/web_request_api.h"
40 #include "extensions/browser/api/web_request/web_request_api_helpers.h" 42 #include "extensions/browser/api/web_request/web_request_api_helpers.h"
41 #include "extensions/browser/bad_message.h" 43 #include "extensions/browser/bad_message.h"
42 #include "extensions/browser/extension_host.h" 44 #include "extensions/browser/extension_host.h"
43 #include "extensions/browser/extension_message_filter.h" 45 #include "extensions/browser/extension_message_filter.h"
44 #include "extensions/browser/extension_registry.h" 46 #include "extensions/browser/extension_registry.h"
45 #include "extensions/browser/extension_service_worker_message_filter.h" 47 #include "extensions/browser/extension_service_worker_message_filter.h"
46 #include "extensions/browser/extension_system.h" 48 #include "extensions/browser/extension_system.h"
47 #include "extensions/browser/guest_view/extensions_guest_view_message_filter.h" 49 #include "extensions/browser/guest_view/extensions_guest_view_message_filter.h"
48 #include "extensions/browser/guest_view/web_view/web_view_renderer_state.h" 50 #include "extensions/browser/guest_view/web_view/web_view_renderer_state.h"
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 char to_origin_copy[256]; 571 char to_origin_copy[256];
570 base::strlcpy(to_origin_copy, to_origin.Serialize().c_str(), 572 base::strlcpy(to_origin_copy, to_origin.Serialize().c_str(),
571 arraysize(to_origin_copy)); 573 arraysize(to_origin_copy));
572 base::debug::Alias(&to_origin_copy); 574 base::debug::Alias(&to_origin_copy);
573 base::debug::DumpWithoutCrashing(); 575 base::debug::DumpWithoutCrashing();
574 576
575 *result = false; 577 *result = false;
576 return true; 578 return true;
577 } 579 }
578 580
581 // Navigations from chrome:// or chrome-search:// pages need to be allowed,
582 // even if |to_url| is not web-accessible. See https://crbug.com/662602.
583 //
584 // Note that this is intentionally done after the check for blob: and
585 // filesystem: URLs above, for consistency with the renderer-side checks
586 // which already disallow navigations from chrome URLs to blob/filesystem
587 // URLs.
588 if (site_url.SchemeIs(content::kChromeUIScheme) ||
589 site_url.SchemeIs(chrome::kChromeSearchScheme)) {
590 *result = true;
591 return true;
592 }
593
579 if (WebAccessibleResourcesInfo::IsResourceWebAccessible(to_extension, 594 if (WebAccessibleResourcesInfo::IsResourceWebAccessible(to_extension,
580 to_url.path())) { 595 to_url.path())) {
581 *result = true; 596 *result = true;
582 return true; 597 return true;
583 } 598 }
584 599
585 if (!site_url.SchemeIsHTTPOrHTTPS() && !site_url.SchemeIs(kExtensionScheme)) { 600 if (!site_url.SchemeIsHTTPOrHTTPS() && !site_url.SchemeIs(kExtensionScheme)) {
586 RecordShowAllowOpenURLFailure( 601 RecordShowAllowOpenURLFailure(
587 FAILURE_SCHEME_NOT_HTTP_OR_HTTPS_OR_EXTENSION); 602 FAILURE_SCHEME_NOT_HTTP_OR_HTTPS_OR_EXTENSION);
588 603
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 command_line->AppendSwitch(switches::kExtensionProcess); 772 command_line->AppendSwitch(switches::kExtensionProcess);
758 } 773 }
759 } 774 }
760 775
761 void ChromeContentBrowserClientExtensionsPart::ResourceDispatcherHostCreated() { 776 void ChromeContentBrowserClientExtensionsPart::ResourceDispatcherHostCreated() {
762 content::ResourceDispatcherHost::Get()->RegisterInterceptor( 777 content::ResourceDispatcherHost::Get()->RegisterInterceptor(
763 "Origin", kExtensionScheme, base::Bind(&OnHttpHeaderReceived)); 778 "Origin", kExtensionScheme, base::Bind(&OnHttpHeaderReceived));
764 } 779 }
765 780
766 } // namespace extensions 781 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698