Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659
Committed: https://crrev.com/93bc2cfbf5ff5d076a06bb599595f256cf47b208
Cr-Commit-Position: refs/heads/master@{#431110}

[rwlbuis, 2016-11-08 20:14:34]

Description was changed from

==========
662659 WIP

BUG=
==========

to

==========
Use parseHTMLInteger in tabIndex

Use parseHTMLInteger in tabIndex to match the one in
Element::parseAttribute. AtomicString::toInt can't handle
214748364.

BUG=662659
==========

[rwlbuis, 2016-11-08 20:16:22]

Description was changed from

==========
Use parseHTMLInteger in tabIndex

Use parseHTMLInteger in tabIndex to match the one in
Element::parseAttribute. AtomicString::toInt can't handle
214748364.

BUG=662659
==========

to

==========
Use parseHTMLInteger in tabIndex

Use parseHTMLInteger in tabIndex to match the one in
Element::parseAttribute. AtomicString::toInt can't
handle -2147483648.

BUG=662659
==========

[rwlbuis, 2016-11-08 20:18:35]

rob.buis@samsung.com changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[rwlbuis, 2016-11-08 20:18:36]

PTAL. This is the quickest fix I could come up with.

Note that there are several similar problems with toInt use recently:
https://bugs.chromium.org/p/chromium/issues/list?can=2&q=toIntegralType

[tkent, 2016-11-08 23:12:25]

Maybe Element::getIntegralAttribute should use parseHTMLInteger.

[rwlbuis, 2016-11-09 01:46:20]

On 2016/11/08 23:12:25, tkent wrote:
> Maybe Element::getIntegralAttribute should use parseHTMLInteger.

Interesting thought. I could try tomorrow. I do wonder if there are legitimate
uses of toInt left if we do that.

[rwlbuis, 2016-11-09 15:19:40]

Description was changed from

==========
Use parseHTMLInteger in tabIndex

Use parseHTMLInteger in tabIndex to match the one in
Element::parseAttribute. AtomicString::toInt can't
handle -2147483648.

BUG=662659
==========

to

==========
Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659
==========

[rwlbuis, 2016-11-09 16:20:00]

On 2016/11/09 01:46:20, rwlbuis wrote:
> On 2016/11/08 23:12:25, tkent wrote:
> > Maybe Element::getIntegralAttribute should use parseHTMLInteger.
> 
> Interesting thought. I could try tomorrow. I do wonder if there are legitimate
> uses of toInt left if we do that.

PTAL. Seems to work great and fix a few more subtests!

[tkent, 2016-11-09 22:43:47]

On 2016/11/09 at 16:20:00, rob.buis wrote:
> PTAL. Seems to work great and fix a few more subtests!

Cool.  LGTM.

[rwlbuis, 2016-11-09 23:14:29]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-09 23:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:45:09]

Description was changed from

==========
Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659
==========

to

==========
Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659
==========

[commit-bot: I haz the power, 2016-11-10 00:45:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 00:48:39]

Description was changed from

==========
Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659
==========

to

==========
Make getIntegralAttribute use parseHTMLInteger

Make getIntegralAttribute use parseHTMLInteger since
AtomicString::toInt can't handle -2147483648 and
it is less spec conformant on whitespace handling.

BUG=662659

Committed: https://crrev.com/93bc2cfbf5ff5d076a06bb599595f256cf47b208
Cr-Commit-Position: refs/heads/master@{#431110}
==========

[commit-bot: I haz the power, 2016-11-10 00:48:41]

Patchset 4 (id:??) landed as
https://crrev.com/93bc2cfbf5ff5d076a06bb599595f256cf47b208
Cr-Commit-Position: refs/heads/master@{#431110}