Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2486793002: Make getIntegralAttribute use parseHTMLInteger (Closed)

Created:
4 years, 1 month ago by rwlbuis
Modified:
4 years, 1 month ago
Reviewers:
tkent, kochi
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make getIntegralAttribute use parseHTMLInteger Make getIntegralAttribute use parseHTMLInteger since AtomicString::toInt can't handle -2147483648 and it is less spec conformant on whitespace handling. BUG=662659 Committed: https://crrev.com/93bc2cfbf5ff5d076a06bb599595f256cf47b208 Cr-Commit-Position: refs/heads/master@{#431110}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : Use parseHTMLInteger in getIntegralAttribute #

Patch Set 4 : Fix test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -169 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-embedded-expected.txt View 1 2 3 3 chunks +6 lines, -126 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-grouping-expected.txt View 1 2 3 2 chunks +2 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
rwlbuis
PTAL. This is the quickest fix I could come up with. Note that there are ...
4 years, 1 month ago (2016-11-08 20:18:36 UTC) #4
tkent
Maybe Element::getIntegralAttribute should use parseHTMLInteger.
4 years, 1 month ago (2016-11-08 23:12:25 UTC) #5
rwlbuis
On 2016/11/08 23:12:25, tkent wrote: > Maybe Element::getIntegralAttribute should use parseHTMLInteger. Interesting thought. I could ...
4 years, 1 month ago (2016-11-09 01:46:20 UTC) #6
rwlbuis
On 2016/11/09 01:46:20, rwlbuis wrote: > On 2016/11/08 23:12:25, tkent wrote: > > Maybe Element::getIntegralAttribute ...
4 years, 1 month ago (2016-11-09 16:20:00 UTC) #8
tkent
On 2016/11/09 at 16:20:00, rob.buis wrote: > PTAL. Seems to work great and fix a ...
4 years, 1 month ago (2016-11-09 22:43:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486793002/60001
4 years, 1 month ago (2016-11-09 23:15:14 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-10 00:45:10 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:48:41 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/93bc2cfbf5ff5d076a06bb599595f256cf47b208
Cr-Commit-Position: refs/heads/master@{#431110}

Powered by Google App Engine
This is Rietveld 408576698