Add static attributes to IDL compiler

Source/bindings/scripts/unstable/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 24 matching lines @@
 For details, see bug http://crbug.com/239771
 """
 
 import v8_types
 import v8_utilities
 from v8_utilities import cpp_method_name, generate_conditional_string, uncapitalize
 
 
 def generate_attributes(interface):
     def generate_attribute(attribute):
-        attribute_contents, attribute_includes = generate_attribute_and_includes(attribute)
+        attribute_contents, attribute_includes = generate_attribute_and_includes(interface, attribute)
         includes.update(attribute_includes)
         return attribute_contents
 
     includes = set()
     contents = generate_attributes_common(interface)
     contents['attributes'] = [generate_attribute(attribute) for attribute in interface.attributes]
     return contents, includes
 
 
 def generate_attributes_common(interface):
     attributes = interface.attributes
     v8_class_name = v8_utilities.v8_class_name(interface)
     return {
         # Size 0 constant array is not allowed in VC++
         'number_of_attributes': 'WTF_ARRAY_LENGTH(%sAttributes)' % v8_class_name if attributes else '0',
         'attribute_templates': '%sAttributes' % v8_class_name if attributes else '0',
     }
 
 
-def generate_attribute_and_includes(attribute):
+def generate_attribute_and_includes(interface, attribute):
     idl_type = attribute.data_type
+    this_getter_name = getter_name(interface, attribute)
+    cpp_value = '%s()' % this_getter_name
     this_is_keep_alive_for_gc = is_keep_alive_for_gc(attribute)
     contents = {
-        'name': attribute.name,
         'conditional_string': generate_conditional_string(attribute),
         'cpp_method_name': cpp_method_name(attribute),

[haraken, 2013/09/27 00:33:31]

This is unused. If we have getter_name, setter_name and method_name, probably we
no longer need cpp_method_name?

[Nils Barth (inactive), 2013/09/27 01:09:33]

Good catch, removed!
(Also some cleanup to v8_utilities followed:
we don't need to import the function here yet, since not yet doing
ImplementedAs.)

         'cpp_type': v8_types.cpp_type(idl_type),
         'is_keep_alive_for_gc': this_is_keep_alive_for_gc,
+        'cpp_value': cpp_value,
+        'is_static': attribute.is_static,
+        'name': attribute.name,
         'v8_type': v8_types.v8_type(idl_type),

[haraken, 2013/09/27 00:33:31]

Reorder these keys. For example: conditional_string => name => is_static =>
is_keep_alive_for_gc => v8_type => cpp_type => cpp_value

[Nils Barth (inactive), 2013/09/27 01:09:33]

Fixed by alphabetizing - is this ok?
(General style for long lists is to alphabetize;
is there some other order or grouping I should use here?)

     }
     if this_is_keep_alive_for_gc:
         includes = v8_types.includes_for_type(idl_type)
         includes.add('bindings/v8/V8HiddenPropertyName.h')
     else:
-        cpp_value = 'imp->%s()' % uncapitalize(attribute.name)
         return_v8_value_statement, includes = v8_types.v8_set_return_value(idl_type, cpp_value, callback_info='info', isolate='info.GetIsolate()', extended_attributes=attribute.extended_attributes, script_wrappable='imp')
         contents['return_v8_value_statement'] = return_v8_value_statement
     return contents, includes
 
 
+def getter_name(interface, attribute):

[haraken, 2013/09/27 00:33:31]

getter_name => cpp_getter_name ?

[Nils Barth (inactive), 2013/09/27 01:09:33]

That's a bit redundant: getter/setter is clearly C++ implementation (not JS
declaration), and everything (except auxiliary functions) is for inclusion in
the C++ output.

If it's *really* useful for clarity (e.g., cpp_type, cpp_value), we should use
cpp_, but otherwise it just makes everything bulky (just like we don't say
attribute_ everywhere).
I'm sure we don't want 'cpp_attribute_getter_function_name', though 'getter' is
a bit too short.

+    getter_base_name = uncapitalize(attribute.name)

[haraken, 2013/09/27 00:33:31]

getter_base_name => getter_method_name ?

[Nils Barth (inactive), 2013/09/27 01:09:33]

Good point, done!

+    if attribute.is_static:
+        return '%s::%s' % (interface.name, getter_base_name)
+    return 'imp->%s' % getter_base_name
+
+
 def is_keep_alive_for_gc(attribute):
     idl_type = attribute.data_type
     extended_attributes = attribute.extended_attributes
     return (
         'KeepAttributeAliveForGC' in extended_attributes or
         # For readonly attributes, for performance reasons we keep the attribute
         # wrapper alive while the owner wrapper is alive, because the attribute
         # never changes.
         (attribute.is_read_only and
          v8_types.wrapper_type(idl_type) and
          # There are some exceptions, however:
          not(
              # Node lifetime is managed by object grouping.
              v8_types.dom_node_type(idl_type) or
              # A self-reference is unnecessary.
              attribute.name == 'self' or
              # FIXME: Remove these hard-coded hacks.
              idl_type in ['SerializedScriptValue', 'Window'] or
              idl_type.startswith('HTML'))))