Add static attributes to IDL compiler

Source/bindings/templates/interface.cpp

 {% extends 'interface_base.cpp' %}
 
 
 {##############################################################################}
 {% block class_attributes %}
 {# FIXME: rename to install_attributes and put into configure_class_template #}
 {% if attributes %}
 static const V8DOMConfiguration::AttributeConfiguration {{v8_class_name}}Attributes[] = {
-{% for attribute in attributes %}
+    {% for attribute in attributes if attribute.is_normal %}

[haraken, 2013/09/26 22:48:30]

Could you use something like 'not if attribute.is_normal' (I don't know jinja
syntax), and remove is_normal ? We don't want to have both is_normal and
is_static.

[Nils Barth (inactive), 2013/09/27 00:26:14]

Removing for now.
In future we will need is_normal, since we need to exclude static,
EnabledAtRuntime, EnabledPerContext, and interface Window { [Unforgeable] }
attributes, but we can do that when we get there.

     {"{{attribute.name}}", {{cpp_class_name}}V8Internal::{{attribute.name}}AttributeGetterCallback, 0, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
-{% endfor %}
+    {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 
 
 {##############################################################################}
 {% block configure_class_template %}
 {# FIXME: rename to install_dom_template and Install{{v8_class_name}}DOMTemplate #}
 static v8::Handle<v8::FunctionTemplate> Configure{{v8_class_name}}Template(v8::Handle<v8::FunctionTemplate> desc, v8::Isolate* isolate, WrapperWorldType currentWorldType)
 {
     desc->ReadOnlyPrototype();
 
     v8::Local<v8::Signature> defaultSignature;
     defaultSignature = V8DOMConfiguration::installDOMClassTemplate(desc, "{{interface_name}}", v8::Local<v8::FunctionTemplate>(), {{v8_class_name}}::internalFieldCount,
         {{attribute_templates}}, {{number_of_attributes}},
         0, 0, isolate, currentWorldType);
     UNUSED_PARAM(defaultSignature);
-{% if constants %}{# In general more checks than just constants #}
+    {% for attribute in attributes if attribute.is_static %}
+    // Attribute '{{attribute.name}}' (Extended Attributes: '{{attribute.extended_attributes | join(' ')}}')

[haraken, 2013/09/26 22:48:30]

Let's remove this comment. This comment has been causing unnecessary
rebaselining of run-bindings-tests.

[Nils Barth (inactive), 2013/09/27 00:26:14]

Done, removed in Perl too!

+    desc->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"), {{cpp_class_name}}V8Internal::{{attribute.name}}AttributeGetterCallback, 0, v8::External::New(0), static_cast<v8::PropertyAttribute>(v8::None), v8::Handle<v8::AccessorSignature>(), static_cast<v8::AccessControl>(v8::DEFAULT));
+    {% endfor %}
+    {% if constants %}{# In general more checks than just constants #}
     v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
     v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();
     UNUSED_PARAM(instance);
     UNUSED_PARAM(proto);
-{% endif %}
-{% if constants %}
+    {% endif %}
+    {% if constants %}
     {{install_constants() | indent}}
-{% endif %}
+    {% endif %}
 
     // Custom toString template
     desc->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::current()->toStringTemplate());
     return desc;
 }
 
 {% endblock %}
 
 
 {######################################}
 {% macro install_constants() %}
 {# FIXME: should use reflected_name instead of name #}
 {# Normal (always enabled) constants #}
 static const V8DOMConfiguration::ConstantConfiguration {{v8_class_name}}Constants[] = {
-{% for constant in constants if not constant.enabled_at_runtime %}
+    {% for constant in constants if not constant.enabled_at_runtime %}
     {"{{constant.name}}", {{constant.value}}},
-{% endfor %}
+    {% endfor %}
 };
 V8DOMConfiguration::installConstants(desc, proto, {{v8_class_name}}Constants, WTF_ARRAY_LENGTH({{v8_class_name}}Constants), isolate);
 {# Runtime-enabled constants #}
 {% for constant in constants if constant.enabled_at_runtime %}
 if ({{constant.runtime_enable_function_name}}()) {
     static const V8DOMConfiguration::ConstantConfiguration constantConfiguration = {"{{constant.name}}", static_cast<signed int>({{constant.value}})};
     V8DOMConfiguration::installConstants(desc, proto, &constantConfiguration, 1, isolate);
 }
 {% endfor %}
 {# Check constants #}
@@ skipping 64 matching lines @@
     V8DOMWrapper::associateObjectWithWrapper<{{v8_class_name}}>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent);
     return wrapper;
 }
 
 void {{v8_class_name}}::derefObject(void* object)
 {
     fromInternalPointer(object)->deref();
 }
 
 {% endblock %}