Touchpad scroll latching enabled for Mac behind flag.

content/browser/renderer_host/input/mouse_wheel_event_queue.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/mouse_wheel_event_queue.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/trace_event/trace_event.h"
 #include "ui/events/blink/web_input_event_traits.h"
@@ skipping 131 matching lines @@
 
       if (event_sent_for_gesture_ack_->event.railsMode ==
           WebInputEvent::RailsModeVertical)
         scroll_update.data.scrollUpdate.deltaX = 0;
       if (event_sent_for_gesture_ack_->event.railsMode ==
           WebInputEvent::RailsModeHorizontal)
         scroll_update.data.scrollUpdate.deltaY = 0;
     }
 
     bool current_phase_ended = false;
+    bool scroll_phase_ended = false;
+    bool momentum_phase_ended = false;
     bool has_phase_info = false;
 
     if (event_sent_for_gesture_ack_->event.phase !=
             blink::WebMouseWheelEvent::PhaseNone ||
         event_sent_for_gesture_ack_->event.momentumPhase !=
             blink::WebMouseWheelEvent::PhaseNone) {
       has_phase_info = true;
-      current_phase_ended = event_sent_for_gesture_ack_->event.phase ==
-                                blink::WebMouseWheelEvent::PhaseEnded ||
-                            event_sent_for_gesture_ack_->event.phase ==
-                                blink::WebMouseWheelEvent::PhaseCancelled ||
-                            event_sent_for_gesture_ack_->event.momentumPhase ==
-                                blink::WebMouseWheelEvent::PhaseEnded ||
-                            event_sent_for_gesture_ack_->event.momentumPhase ==
-                                blink::WebMouseWheelEvent::PhaseCancelled;
+      scroll_phase_ended = event_sent_for_gesture_ack_->event.phase ==
+                               blink::WebMouseWheelEvent::PhaseEnded ||
+                           event_sent_for_gesture_ack_->event.phase ==
+                               blink::WebMouseWheelEvent::PhaseCancelled;
+      momentum_phase_ended = event_sent_for_gesture_ack_->event.momentumPhase ==
+                                 blink::WebMouseWheelEvent::PhaseEnded ||
+                             event_sent_for_gesture_ack_->event.momentumPhase ==
+                                 blink::WebMouseWheelEvent::PhaseCancelled;
+      current_phase_ended = scroll_phase_ended || momentum_phase_ended;
     }
 
     bool needs_update = scroll_update.data.scrollUpdate.deltaX != 0 ||
                         scroll_update.data.scrollUpdate.deltaY != 0;
 
     // If there is no update to send and the current phase is ended yet a GSB
     // needs to be sent, this event sequence doesn't need to be generated
     // because the events generated will be a GSB (non-synthetic) and GSE
     // (non-synthetic). This situation arises when OSX generates double
     // phase end information.
     bool empty_sequence =
         !needs_update && needs_scroll_begin_ && current_phase_ended;
 
-    if (needs_update || !empty_sequence) {
-      if (needs_scroll_begin_) {
-        // If no GSB has been sent, it will be a non-synthetic GSB.
-        SendScrollBegin(scroll_update, false);
-      } else if (has_phase_info) {
-        // If a GSB has been sent, generate a synthetic GSB if we have phase
-        // information. This should be removed once crbug.com/526463 is fully
-        // implemented.
-        SendScrollBegin(scroll_update, true);
+    if (enable_scroll_latching_) {
+      if (event_sent_for_gesture_ack_->event.momentumPhase ==
+          blink::WebMouseWheelEvent::PhaseBegan) {
+        // Don't send the pending scrollEnd if a fling starts.
+        if (scroll_end_timer_.IsRunning())
+          scroll_end_timer_.Stop();
       }
 
-      if (needs_update) {
-        ui::LatencyInfo latency = ui::LatencyInfo(ui::SourceEventType::WHEEL);
-        latency.AddLatencyNumber(
-            ui::INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL, 0,
-            0);
-        client_->ForwardGestureEventWithLatencyInfo(scroll_update, latency);
+      if (needs_update || !empty_sequence) {
+        if (needs_scroll_begin_) {
+          SendScrollBegin(scroll_update, false);
+        }
+
+        if (needs_update) {
+          ui::LatencyInfo latency = ui::LatencyInfo(ui::SourceEventType::WHEEL);
+          latency.AddLatencyNumber(
+              ui::INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL,
+              0, 0);
+          client_->ForwardGestureEventWithLatencyInfo(scroll_update, latency);
+        }
+
+        if (momentum_phase_ended) {
+          // Send GSE with if scroll latching is enabled and no fling is going
+          // to happen next.
+          SendScrollEnd(scroll_update, false);
+        } else if (scroll_phase_ended || !has_phase_info) {
+          // If scroll latching is enabled and a fling might happen next, or
+          // no phase info exists, start the scroll_end_timer_.
+          scroll_end_timer_.Start(
+              FROM_HERE,
+              base::TimeDelta::FromMilliseconds(scroll_transaction_ms_),
+              base::Bind(&MouseWheelEventQueue::SendScrollEnd,
+                         base::Unretained(this), scroll_update, false));
+        }
       }
 
-      if (current_phase_ended) {
-        // Non-synthetic GSEs are sent when the current phase is canceled or
-        // ended.
-        SendScrollEnd(scroll_update, false);
-      } else if (has_phase_info) {
-        // Generate a synthetic GSE for every update to force hit testing so
-        // that the non-latching behavior is preserved. Remove once
-        // crbug.com/526463 is fully implemented.
-        SendScrollEnd(scroll_update, true);
-      } else {
-        scroll_end_timer_.Start(
-            FROM_HERE,
-            base::TimeDelta::FromMilliseconds(scroll_transaction_ms_),
-            base::Bind(&MouseWheelEventQueue::SendScrollEnd,
-                       base::Unretained(this), scroll_update, false));
+    } else {  // !enable_scroll_latching_
+      if (needs_update || !empty_sequence) {
+        if (needs_scroll_begin_) {
+          // If no GSB has been sent, it will be a non-synthetic GSB.
+          SendScrollBegin(scroll_update, false);
+        } else if (has_phase_info) {
+          // If a GSB has been sent, generate a synthetic GSB if we have phase
+          // information. This should be removed once crbug.com/526463 is
+          // fully implemented.
+          SendScrollBegin(scroll_update, true);
+        }
+
+        if (needs_update) {
+          ui::LatencyInfo latency = ui::LatencyInfo(ui::SourceEventType::WHEEL);
+          latency.AddLatencyNumber(
+              ui::INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL,
+              0, 0);
+          client_->ForwardGestureEventWithLatencyInfo(scroll_update, latency);
+        }
+
+        if (current_phase_ended) {
+          // Non-synthetic GSEs are sent when the current phase is canceled or
+          // ended.
+          SendScrollEnd(scroll_update, false);
+        } else if (has_phase_info) {
+          // Generate a synthetic GSE for every update to force hit testing so
+          // that the non-latching behavior is preserved. Remove once
+          // crbug.com/526463 is fully implemented.
+          SendScrollEnd(scroll_update, true);
+        } else if (!has_phase_info) {
+          scroll_end_timer_.Start(
+              FROM_HERE,
+              base::TimeDelta::FromMilliseconds(scroll_transaction_ms_),
+              base::Bind(&MouseWheelEventQueue::SendScrollEnd,
+                         base::Unretained(this), scroll_update, false));
+        }
       }
     }
   }
 
   event_sent_for_gesture_ack_.reset();
   TryForwardNextEventToRenderer();
 }
 
 void MouseWheelEventQueue::OnGestureScrollEvent(
     const GestureEventWithLatencyInfo& gesture_event) {
@@ skipping 74 matching lines @@
   scroll_begin.data.scrollBegin.deltaHintUnits =
       gesture_update.data.scrollUpdate.deltaUnits;
 
   needs_scroll_begin_ = false;
   needs_scroll_end_ = true;
   client_->ForwardGestureEventWithLatencyInfo(
       scroll_begin, ui::LatencyInfo(ui::SourceEventType::WHEEL));
 }
 
 }  // namespace content