Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2486673007: Revert of Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue (Closed)

Created:
4 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org, altimin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue (patchset #9 id:200001 of https://codereview.chromium.org/2464853002/ ) Reason for revert: Long term I'd like to reland this, after the perf regression has been sorted out. Data from this helped fix a number of bugs. https://bugs.chromium.org/p/chromium/issues/detail?id=661927&can=8&q=2464853002&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified Original issue's description: > Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue > > We suspect a bad task closure is getting posted and would like to > add crash keys to aid diagnosis. > > BUG=660427, 661927 > > Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a > Cr-Commit-Position: refs/heads/master@{#429285} TBR=rsesek@chromium.org,skyostil@chromium.org,ananta@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660427, 661927 Committed: https://crrev.com/a706db8b1ae44c392ac9b518a2d93e88d4b891fd Cr-Commit-Position: refs/heads/master@{#431551}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
alex clarke (OOO till 29th)
Created Revert of Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue
4 years, 1 month ago (2016-11-11 10:32:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486673007/1
4 years, 1 month ago (2016-11-11 10:32:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:00:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 13:02:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a706db8b1ae44c392ac9b518a2d93e88d4b891fd
Cr-Commit-Position: refs/heads/master@{#431551}

Powered by Google App Engine
This is Rietveld 408576698