Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2486653004: Import wpt@2782308f4187e73043324272552cf1bd90edc784 (Closed)

Created:
4 years, 1 month ago by blink-w3c-test-autoroller
Modified:
4 years, 1 month ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dom-dev_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import wpt@2782308f4187e73043324272552cf1bd90edc784 Using update-w3c-deps in Chromium c49f0e4d6c1ff0776f244457f3693a289cc292ec. TBR=qyearsley@chromium.org Committed: https://crrev.com/47c33a2dd803279fbb08ab3215e0c8038adb0cb7 Cr-Commit-Position: refs/heads/master@{#430631}

Patch Set 1 #

Patch Set 2 : Modify TestExpectations or download new baselines for tests. #

Messages

Total messages: 10 (2 generated)
blink-w3c-test-autoroller
Modify TestExpectations or download new baselines for tests.
4 years, 1 month ago (2016-11-08 15:38:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486653004/20001
4 years, 1 month ago (2016-11-08 15:39:05 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 16:36:31 UTC) #4
qyearsley
lgtm
4 years, 1 month ago (2016-11-08 16:37:43 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/47c33a2dd803279fbb08ab3215e0c8038adb0cb7 Cr-Commit-Position: refs/heads/master@{#430631}
4 years, 1 month ago (2016-11-08 16:42:28 UTC) #7
xlai (Olivia)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2483293002/ by xlai@chromium.org. ...
4 years, 1 month ago (2016-11-08 18:07:05 UTC) #8
tkent
Adding platform-specific *-expected.txt is not correct. htmlallcollection.html must be platform-independent.
4 years, 1 month ago (2016-11-08 22:52:12 UTC) #9
qyearsley
4 years, 1 month ago (2016-11-08 23:00:51 UTC) #10
Message was sent while issue was closed.
On 2016/11/08 at 22:52:12, tkent wrote:
> Adding platform-specific *-expected.txt is not correct. 
htmlallcollection.html must be platform-independent.

Yep - something went wrong with the rebaseline - I'm now trying the auto
importer again to see if it makes the same mistake
(https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...)

Powered by Google App Engine
This is Rietveld 408576698