Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2486623002: [Devtools] Added padding to hover area in network timeline (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added padding to hover area in network timeline This patch allows for a minimum of 25px on each side of the bars in network waterfall. R=dgozman BUG=653738 Committed: https://crrev.com/62980b89a07d6575426fb148822341c4ba07db2e Cr-Commit-Position: refs/heads/master@{#430688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
allada
PTL
4 years, 1 month ago (2016-11-08 02:02:30 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-08 16:44:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486623002/1
4 years, 1 month ago (2016-11-08 18:13:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 19:49:54 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 20:10:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62980b89a07d6575426fb148822341c4ba07db2e
Cr-Commit-Position: refs/heads/master@{#430688}

Powered by Google App Engine
This is Rietveld 408576698