Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2486573002: Provide LINE_INFO using just UnlinkedUnit even though the full info is not available. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Provide LINE_INFO using just UnlinkedUnit even though the full info is not available. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ceda6a038b3b7a0961a1544f3e39a55855030c37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-07 23:10:15 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-07 23:12:22 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-07 23:46:37 UTC) #3
scheglov
4 years, 1 month ago (2016-11-09 02:11:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ceda6a038b3b7a0961a1544f3e39a55855030c37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698